324239 - Warning - Unresponsive script button choices graphics reversed

Status: RESOLVED INVALID

(Core :: DOM: Core & HTML, defect)

Description

[Letts]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: Firefox/1.5

This page usually has too much to send us, resulting in an error message from FF about unresponsive script.  There are two buttons: 1) Stop script, with a green checkmark and 2) Continue, with a red X.
Logic would suggest the Stop should have the red X and Continue should have the green check - like a stop light says red for stop, green to go (ahead).

Reproducible: Always

Steps to Reproduce:
1. your computer only need be slow enough, or the Internet busy enough, to make the message come up.
2.
3.

Comment 1

[Dave Townsend [:mossop]]

Couldn't reproduce, but from memory that dialog does not have checkboxes on it. Are you using firefox's default theme?

Comment 2

[Letts]

These are not check boxes, only buttons with wrong graphics.

Comment 3

[Dave Townsend [:mossop]]

Sorry, I meant graphics. Are you using the default firefox theme?

Comment 4

[Letts]

Using Microfirefox 1.027.  Didn't even think about these being art of themes.  Not that normally involved at this level but trying to make a great product better.

Comment 5

[Dave Townsend [:mossop]]

The prompt that is used to display this warning is a very generic one and I think your theme is just assuming that the first button is an equivalent of "Ok" and the second of "Cancel" which in this case doesn't really apply.

I suspect this is invalid but moving to the right component for further review.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

That dialog uses the prompt service to display the dialog, which uses commonDialog.xul/js. The first argument it passes is the "stop" string:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/dom/src/base/nsJSEnvironment.cpp&rev=1.275&mark=597#592
which gets mapped to eButton0Text:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/embedding/components/windowwatcher/src/nsPromptService.cpp&rev=1.29&mark=294,328#294
which is "8":
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/embedding/components/windowwatcher/public/nsPIPromptService.idl&mark=52&rev=1.9#52
which gets mapped to the "accept" button at:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/content/commonDialog.js&rev=1.10&mark=156,158#142
which the Minifirefox theme correctly styles as the "checkmark" button.

Since "stop script" is the choice most users want when presented with this dialog, I think setting it to be the accept button makes sense. The fact that the theme's style for this dialog seems counterintuitive is problem with the specific theme, not Firefox, so resolving invalid.