remove openApplication(NEWS/MAIL) from the shell service

NEW
Assigned to

Status

()

13 years ago
7 years ago

People

(Reporter: Gavin, Assigned: mano)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

openApplication(APPLICATION_MAIL) and openApplication(APPLICATION_NEWS) are no longer used, which means openApplication can be removed for GNOME/Win, and trimmed for Mac (it seems to have other unused targets, APPLICATION_KEYCHAIN_ACCESS, APPLICATION_NETWORK, but I'm guessing those are meant to be used in the future?). nsWindowsShellService's GetUnreadMailCount is also no longer used and can be removed.

I don't know whether removing these is necessarily a good idea - it would save on codesize, but I can imagine they may be commonly used by extensions. Ben mentioned it in bug 306453, so filing this for discussion.
Created attachment 209306 [details] [diff] [review]
potential patch

This builds on Windows, but hasn't been tested. I moved openApplication to nsIMacShellService since it still had a APPLICATION_DESKTOP caller on the Mac. This seems like it has the potential to break a lot of extensions.
Priority: -- → P4
Status: NEW → ASSIGNED
OS: All → Windows XP
OS: Windows XP → All
Assignee: gavin.sharp → nobody
Status: ASSIGNED → NEW
Priority: P4 → --
Target Milestone: Firefox 3 → ---

Updated

8 years ago
Blocks: 411043
Assignee: nobody → mano
unreadlMailCount was removed in bug 693227
Summary: remove openApplication(NEWS/MAIL) and GetUnreadMailCount from the shell service → remove openApplication(NEWS/MAIL) from the shell service
You need to log in before you can comment on or make changes to this bug.