Closed Bug 324361 Opened 14 years ago Closed 4 months ago

Remove openApplication/openApplicationWithURI from the shell service, but keep a function on Mac to open the desktop background app

Categories

(Firefox :: Shell Integration, defect)

defect
Not set
Points:
2

Tracking

()

RESOLVED FIXED
Firefox 70
Iteration:
70.4 - Aug 19 - Sep 1
Tracking Status
firefox70 --- fixed

People

(Reporter: Gavin, Assigned: standard8)

References

Details

(Whiteboard: [lang=cpp])

Attachments

(2 files)

openApplication(APPLICATION_MAIL) and openApplication(APPLICATION_NEWS) are no longer used, which means openApplication can be removed for GNOME/Win, and trimmed for Mac (it seems to have other unused targets, APPLICATION_KEYCHAIN_ACCESS, APPLICATION_NETWORK, but I'm guessing those are meant to be used in the future?). nsWindowsShellService's GetUnreadMailCount is also no longer used and can be removed.

I don't know whether removing these is necessarily a good idea - it would save on codesize, but I can imagine they may be commonly used by extensions. Ben mentioned it in bug 306453, so filing this for discussion.
Attached patch potential patchSplinter Review
This builds on Windows, but hasn't been tested. I moved openApplication to nsIMacShellService since it still had a APPLICATION_DESKTOP caller on the Mac. This seems like it has the potential to break a lot of extensions.
Priority: -- → P4
Status: NEW → ASSIGNED
Assignee: gavin.sharp → nobody
Status: ASSIGNED → NEW
Priority: P4 → --
Target Milestone: Firefox 3 → ---
Blocks: 411043
unreadlMailCount was removed in bug 693227
Summary: remove openApplication(NEWS/MAIL) and GetUnreadMailCount from the shell service → remove openApplication(NEWS/MAIL) from the shell service
Assignee: asaf → nobody

I'm happy to mentor someone on this.

I think the final aims of the patch here should be:

  • Remove openApplication and openApplicationWithURI from the shell service (and associated constants)
  • Implement a openDesktopBackgroundApp function for nsIMacShellService that does the same as what openApplication(Ci.nsIMacShellService.APPLICATION_DESKTOP); does now.

Hints:

Mentor: standard8
Keywords: good-first-bug
Summary: remove openApplication(NEWS/MAIL) from the shell service → Remove openApplication/openApplicationWithURI from the shell service, but keep a function on Mac to open the desktop background app
Whiteboard: [lang=cpp]
Blocks: 336107

Hi @Mark I would like to work on it , can I take this up?

Thanks

Flags: needinfo?(standard8)

Hey,
I'm an outreachy 2019 applicant. Can I take up this issue and work on it?

Assigning to Shivam as they asked first.

@Aashna, you can find possible other bugs at https://codetribute.mozilla.org/

Assignee: nobody → shivams2799
Status: NEW → ASSIGNED
Flags: needinfo?(standard8)
Assignee: shivams2799 → nobody
Status: ASSIGNED → NEW

No more takers, so maybe it wasn't a good mentored bug for some reason or just not found. In any case, quick late Friday afternoon patch time.

Assignee: nobody → standard8
Mentor: standard8
Keywords: good-first-bug

Keeps a function for opening the Mac desktop preferences.

Note, if you want to test this, right-click on an image and select "Set As Desktop Background", then hit the "Set Desktop Background" button, and it will change and let you open up the preferences.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=20a5bb8372569cea8cdc231ae5cfd5d038ff8fea

Points: --- → 2
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f4da3ae7efa6
Remove openApplication/openApplicationWithURI from the shell service as they aren't used. r=mossop
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Blocks: 688885
Iteration: --- → 70.4 - Aug 19 - Sep 1
You need to log in before you can comment on or make changes to this bug.