Rename form history database

RESOLVED FIXED in Firefox 2 alpha1

Status

()

Firefox
Bookmarks & History
P3
normal
RESOLVED FIXED
13 years ago
9 years ago

People

(Reporter: Brett Wilson, Assigned: Brian Ryner (not reading))

Tracking

Trunk
Firefox 2 alpha1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

13 years ago
If it is low-overhead enough to have a separate database file open, we should move form history into its own database file.
Priority: -- → P3
Target Milestone: --- → Firefox 2 alpha1
(Assignee)

Updated

13 years ago
Depends on: 325287
(Assignee)

Comment 1

13 years ago
Created attachment 211539 [details] [diff] [review]
patch

This renames both the bookmarks/history and form history databases like we discussed.  In the process, I discovered that testbookmarks.js had fallen out of date with the default bookmarks, so I fixed it.  Execution of testbookmarks.js with xpcshell crashes on exit, somewhere in the cache code.  It might be because we're now making a profile directory available, but not initializing something correctly.  I'll talk to Darin about it, but I don't think it's critical for now.
Attachment #211539 - Flags: review?(brettw)
(Reporter)

Comment 2

12 years ago
Comment on attachment 211539 [details] [diff] [review]
patch

>+  rv =dbFile->Append(NS_LITERAL_STRING("bookmarks_history.sqlite"));

Stupid nit: need space.
Attachment #211539 - Flags: review?(brettw) → review+
(Assignee)

Comment 3

12 years ago
checked in.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.