Finish remote container API

RESOLVED FIXED

Status

()

P2
normal
RESOLVED FIXED
13 years ago
9 years ago

People

(Reporter: brettw, Assigned: brettw)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
 
(Assignee)

Updated

13 years ago
Priority: -- → P2
(Assignee)

Comment 1

13 years ago
Created attachment 209715 [details] [diff] [review]
Patch

In addition to the container API, this patch also:
- Renames BookmarksContainer to RemoteContainer
- Removes RESULT_TYPE_DAY which was unimplemented, and replaced it with RESULT_TYPE_REMOTE_CONTAINER to identify remote containers that are not bookmark folders.
- Fixes a bug in BookmarkService::RemoveFolderChildren
- Replaces leaky calls to QueryStringToQueries with a new nsCOMArray version that should be less error-prone
- Replaces most uses of nsINavHistoryQuery arrays to use COM arrays of the concrete class, which simplified a lot of code
- Fixes a bunch of signed/unsigned warnings in the livemark service
- Cleaned up result containers to remove the unused access count and time parameters in the constructors.
- Renamed the serialized version of bookmark folders from "folders=" to "folder=" since there is only one folder per item, which was confusing even me.
Attachment #209715 - Flags: review?(bryner)
Attachment #209715 - Flags: review?(bryner) → review+
(Assignee)

Comment 2

13 years ago
On trunk and 1.8 branch.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.