Bookmark queries should handle absence of GROUP_BY_FOLDER

RESOLVED WONTFIX

Status

()

P2
normal
RESOLVED WONTFIX
13 years ago
9 years ago

People

(Reporter: brettw, Assigned: brettw)

Tracking

Trunk
Firefox 2 beta1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

13 years ago
Currently, we generate bookmark folders regardless or grouping. However, we should only do this when you request group by folder. Grouping by something else should result in a regular query with only URLs in it grouped as you requested.

We will need to change every place we create a nsNavHistoryFolderResultNode and add this detection to GetSimpleBookmarksQueryFolder.
Priority: -- → P2
What issues does this resolve? Targeting at f2b1 until that becomes clear ;-) 
Target Milestone: --- → Firefox 2 beta1
(Assignee)

Comment 2

13 years ago
Currently this the "problem" is not visible. When you do a query for everything in folder A, you should get back a flat list of all items in A and its descendents. When you do the same query grouped by folder, you should get back a hierarchy rooted at A. Currently, we always do the latter.

This would be useful to people using bookmarks as tags. We'll need to do this before release so people don't start using the other way and then we can never add the flat list capability.
(Assignee)

Comment 3

13 years ago
GROUP_BY_FOLDER is getting removed as per bug 331487, so fixing it is not necessary.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → WONTFIX
Summary: Bookmark queries should handle absense GROUP_BY_FOLDER → Bookmark queries should handle absence of GROUP_BY_FOLDER
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.