Closed Bug 324617 Opened 18 years ago Closed 18 years ago

[adblocking] doesn't block the ad image

Categories

(Camino Graveyard :: General, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Camino1.0

People

(Reporter: promo, Assigned: alqahira)

References

()

Details

(Keywords: fixed1.8.0.2, fixed1.8.1, Whiteboard: [camino-1.0])

Attachments

(1 file, 2 obsolete files)

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.1) Gecko/20060121 Camino/1.0b2+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.1) Gecko/20060121 Camino/1.0b2+

the fash ad is not blocked

Reproducible: Always

Steps to Reproduce:
the logo url is within the source code
Here is the url to the flash file, http://as1.falkag.de/sel?cmd=ifr&kid=234347&dat=512505&xl=300&yl=200

This seems a resonble request. We already block flash from falkag.net.
Also a couple of iframes from http://as1.falkag.de/

Can we condense our existing domain and subdomain-specific falkag rules into rules something like [href/src*=".falkag."] ?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: doesn't block the ad image → [adblocking] doesn't block the ad image
While we're on the subject of German ads not being blocked, the page in bug 324619 has two flash ads with this sort of url: http://a.ads.t-online.de/dat/bgf/ 
Assignee: mikepinkerton → sfraser_bugs
This patch converts all of our falkag references to use .falkag. to catch all the falkag domains.  (With this patch, I no longer see the ads.t-online.de flash stuff, oddly enough.)
Attachment #210211 - Flags: review?(sfraser_bugs)
Comment on attachment 210211 [details] [diff] [review]
patch to convert our falkag refs to .falkag.

Might as well throw an 
img[src*=".falkag."]
in there too.
Attachment #210211 - Flags: review?(sfraser_bugs) → review+
Attached patch Updated patch (obsolete) — Splinter Review
This patch addresses comment 5, comment 3, and bug 323985 as well.
Attachment #210211 - Attachment is obsolete: true
Attachment #211565 - Flags: review?(sfraser_bugs)
Since we haven't actively sought to audit our ad-blocking on non-American sites (Sam and I did ask caminol10n to file bugs if they found things) and this is the only bug about European ads that's been filed, it would be nice to get this into 1.0 if possible.
Assignee: sfraser_bugs → alqahira
Blocks: 323985
Target Milestone: --- → Camino1.0
Could you fold in these changes too? -

Index: ad_blocking.css
===================================================================
RCS file: /cvsroot/mozilla/camino/resources/application/ad_blocking.css,v
retrieving revision 1.17
diff -u -r1.17 ad_blocking.css
--- ad_blocking.css	15 Jan 2006 20:31:18 -0000	1.17
+++ ad_blocking.css	12 Feb 2006 16:53:50 -0000
@@ -46,6 +46,7 @@
 a:link[href*="/banman.asp?"] img,
 a:link[href*="adsys.townnews.com"] img,
 a:link[href*="ak.m3.net"] img,
+a:link[href*=".pointroll.com"] img,
 
 embed[src*="/us.yimg.com/a/"],
 embed[type="application/x-shockwave-flash"][src*="/ad."],
@@ -86,6 +87,7 @@
 embed[type="application/x-shockwave-flash"][src*=".netshelter.net"],
 embed[type="application/x-shockwave-flash"][src*=".gms1.net"],
 embed[type="application/x-shockwave-flash"][src*="ak.m3.net"],
+embed[type="application/x-shockwave-flash"][src*=".pointroll.com"],
 
 img[src*="googlesyndication.com"],
 img[src*="ad.doubleclick.net"],
@@ -119,6 +121,7 @@
 img[src*=".gms1.net"],
 img[src*="ak.m3.net"],
 img[src*="atdmt.com"],
+img[src*=".pointroll.com"],
 
 iframe[src*="/ad."],
 iframe[src*="/ads."],
@@ -168,6 +171,7 @@
 iframe[src*=".gms1.net"],
 iframe[src*="ak.m3.net"],
 iframe[src*="adsvr.adknowledge.com"],
+iframe[src*=".pointroll.com"],
 
 table#overtureLinksWrapper,
 table.adbritetable,
Sure!
Attachment #211565 - Attachment is obsolete: true
Attachment #211602 - Flags: review?(sfraser_bugs)
Attachment #211565 - Flags: review?(sfraser_bugs)
Attachment #211602 - Flags: review?(sfraser_bugs) → review+
Sure, I don't see why not.
Flags: camino1.0+
Checked in: trunk, 1_8, 1_8_0, 1_0
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [camino-1.0]
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: