The chartgroup, insidergroup and timetrackinggroup groups in editparams.cgi should be listed in a dropdown menu

RESOLVED FIXED in Bugzilla 3.0

Status

()

Bugzilla
Administration
--
enhancement
RESOLVED FIXED
13 years ago
12 years ago

People

(Reporter: Frédéric Buclin, Assigned: Frédéric Buclin)

Tracking

2.21
Bugzilla 3.0
Dependency tree / graph
Bug Flags:
approval +

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
This doesn't make sense to "guess" the group names. We already moved from a text field to a dropdown menu in editflagtypes.cgi, we should do the same here. It's boring to manually enter the group names and then realize this doesn't work because you did a typo.

I would even tend to take it for 2.22, but that's probably too late.
(Assignee)

Comment 1

13 years ago
Note also that there is no check about entered groups. editparams.cgi should at least make sure the groups you entered are valid ones. In the same way, editgroups.cgi should:
1) update the group in editparams.cgi when a group used by it is renamed;
2) reject to delete a group if the group is used by editparams.cgi.

I will fill a new bug for editgroups.cgi. And let fix editparams.cgi here.
Status: NEW → ASSIGNED
(Assignee)

Updated

13 years ago
Blocks: 324784
(Assignee)

Updated

12 years ago
No longer blocks: 324784
Depends on: 324784
(Assignee)

Comment 2

12 years ago
Created attachment 226365 [details] [diff] [review]
patch, v1
Attachment #226365 - Flags: review?(wicked+bz)

Comment 3

12 years ago
Comment on attachment 226365 [details] [diff] [review]
patch, v1

>Index: Bugzilla/Config/Common.pm
>+sub check_group {
>+    my $group_name = shift;
>+    my $group = new Bugzilla::Group({'name' => $group_name});
>+    unless (defined $group) {
>+        return "Must be an existing group name";
>+    }
>+    return "";
>+}
>+

Nit:

It may be personal, but I'd prefer:

  return "Must be an existing group name" unless defined $group;
Attachment #226365 - Flags: review+

Updated

12 years ago
Attachment #226365 - Flags: review?(wicked+bz) → review+
(Assignee)

Updated

12 years ago
Flags: approval?
Flags: approval? → approval+
(Assignee)

Comment 4

12 years ago
Checking in Bugzilla/Group.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Group.pm,v  <--  Group.pm
new revision: 1.13; previous revision: 1.12
done
Checking in Bugzilla/Config/Common.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/Common.pm,v  <--  Common.pm
new revision: 1.9; previous revision: 1.8
done
Checking in Bugzilla/Config/GroupSecurity.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/GroupSecurity.pm,v  <--  GroupSecurity.pm
new revision: 1.4; previous revision: 1.3
done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

12 years ago
Blocks: 342861
(Assignee)

Updated

12 years ago
Blocks: 344448
You need to log in before you can comment on or make changes to this bug.