Convert directory contents array in nsDirectoryIndexStream to nsCOMArray

RESOLVED FIXED in mozilla1.9alpha1

Status

()

Core
Networking: File
--
minor
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Waldo, Assigned: Waldo)

Tracking

Trunk
mozilla1.9alpha1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

All the elements in the array are nsIFile objects, so it makes sense to use nsCOMArray and thus not have to worry as much about refcounting or releasing each element in the array when the stream goes away.
Created attachment 209912 [details] [diff] [review]
Patch
Attachment #209912 - Flags: superreview?(darin)
Attachment #209912 - Flags: review?(darin)

Comment 2

12 years ago
Comment on attachment 209912 [details] [diff] [review]
Patch

nice, thanks!  r+sr=darin
Attachment #209912 - Flags: superreview?(darin)
Attachment #209912 - Flags: superreview+
Attachment #209912 - Flags: review?(darin)
Attachment #209912 - Flags: review+
Patch checked in with a change to remove the temporary nsIFile* used when adding each file to mArray (the result of review comments on similar code in bug 309296), so marking FIXED.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha
You need to log in before you can comment on or make changes to this bug.