Closed
Bug 324815
Opened 20 years ago
Closed 20 years ago
Convert directory contents array in nsDirectoryIndexStream to nsCOMArray
Categories
(Core :: Networking: File, defect)
Core
Networking: File
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: Waldo, Assigned: Waldo)
References
()
Details
Attachments
(1 file)
|
5.72 KB,
patch
|
darin.moz
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
All the elements in the array are nsIFile objects, so it makes sense to use nsCOMArray and thus not have to worry as much about refcounting or releasing each element in the array when the stream goes away.
|
Assignee | |
Comment 1•20 years ago
|
||
Attachment #209912 -
Flags: superreview?(darin)
Attachment #209912 -
Flags: review?(darin)
|
||
Comment 2•20 years ago
|
||
Comment on attachment 209912 [details] [diff] [review]
Patch
nice, thanks! r+sr=darin
Attachment #209912 -
Flags: superreview?(darin)
Attachment #209912 -
Flags: superreview+
Attachment #209912 -
Flags: review?(darin)
Attachment #209912 -
Flags: review+
|
|
Assignee | |
Comment 3•20 years ago
|
||
Patch checked in with a change to remove the temporary nsIFile* used when adding each file to mArray (the result of review comments on similar code in bug 309296), so marking FIXED.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha
You need to log in
before you can comment on or make changes to this bug.
Description
•