324829 - toolkit windows installer is brittle on line endings during build

Status: RESOLVED FIXED

(Toolkit Graveyard :: Build Config, defect)

Description

[Axel Hecht [:Pike]]

If toolkit/installer/windows/install.it doesn't have a trailing newline, the
build creates a install.ini in the build that looks somewhat like this:

ERROR_PATH_WITHIN_WINDIR=Programa negali b<FB>ti <E1>diegta <E1> <84>Windows<93>
 katalogo pakatalog<E1>. Pra<F0>om parinkti kit<E0> katalog<E0>.AB_CD=lt

I.e., it doesn't have the define for AB_CD or some other entity, which completely
confuses the installer. And leads to crashes.

This happened both for cz 1.5 rc1 and lt 1.5.0.1 candidate.

Comment 1

[Tatjana Jevsikova]

Attachment: Patch for lt install.it

Attaching a patch for lt toolkit/installer/windows/installer.it with new lines at the end of file added.
Could I commit it to 1_8_0, 1_8 branches?

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 209815 [details] [diff] [review]
Patch for lt install.it

I already did ;-)

Comment 3

[Axel Hecht [:Pike]]

install.it is not cvs removed yet, but dead anyway. Closing.