324865 - Move XMLHttpRequest to gklayout

Status: RESOLVED FIXED

(Core :: XML, defect, P2)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

We need to get XMLHttpRequest into gklayout to be able to use some GC helper utilities that live there. And we're never going to ship gecko without XMLHttpRequest anyway so there's not much point to keeping it in mozilla/extensions.

So we could either move it to mozilla/content/base, or to dom/src/base. Oppinions? Takers?

Comment 1

[Peter Van der Beken [:peterv]]

I vote for mozilla/content/base.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

also note bug 315890

Comment 3

[Peter Van der Beken [:peterv]]

(In reply to comment #2)
> also note bug 315890

Sure, but that didn't help for DOMCI.

Comment 4

[Peter Van der Beken [:peterv]]

Attachment: Changes to existing files - v1

Comment 5

[Peter Van der Beken [:peterv]]

Attachment: Changes to files to cvs move - v1

Comment 6

[Peter Van der Beken [:peterv]]

We hit an assert in nsDOMClassInfo::PostCreate (http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/dom/src/base/nsDOMClassInfo.cpp&rev=1.351#3285) because nsIDOMParser should really be named nsIDOMDOMParser.

Comment 7

[Peter Van der Beken [:peterv]]

Attachment: Changes to existing files - v1.1

This one doesn't hit assertions in DOMCI.

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

The interface isn't frozen so we could in theory rename it nsIDOMDOMParser

Comment 9

[Peter Van der Beken [:peterv]]

Attachment: CVS moves - v1

Comment 10

[Peter Van der Beken [:peterv]]

Comment on attachment 211260 [details]
CVS moves - v1

Looking for moa on the new locations. I thought about moving them to content/xml, but that'd require a new content/xml subdirectory (doesn't really fit in content or document).

Comment 11

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Alternativly, we could merge the xml/content/* and xml/document/* directories into just xml/*. But that might be a bigger change then this bug.

Comment 12

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

reverting accidental owner change

Comment 13

[Johnny Stenback (:jst)]

Comment on attachment 211260 [details]
CVS moves - v1

r+sr=jst

Comment 14

[Peter Van der Beken [:peterv]]

Attachment: v1.1

Comment 15

[Peter Van der Beken [:peterv]]

Attachment: Files to cvs rm v1

Comment 16

[Johnny Stenback (:jst)]

Comment on attachment 219137 [details] [diff] [review]
v1.1

r+sr=jst

Comment 17

[Peter Van der Beken [:peterv]]

Finally done, sorry about the delays.

Comment 18

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 219137 [details] [diff] [review]
v1.1

So I'd like to merge this to the 1.8 branch (see bug 336791), but I'm going to request approval for this one separately because it's a large patch, and I'd rather not have it be part of my diff in bug 336791.

Comment 19

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch for 1.8 branch

Here's an actual merged patch.  I'll also attach a diff showing what changed after doing the cvs adds and removes.

I haven't done any runtime testing of this yet since I built with a bad configuration.  I'll be able to test it in a few hours, but hoping to get approval before you're asleep, perhaps.

Comment 20

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: interdiff against post-add/remove for 1.8 branch

Here's the interdiff showing what actually changed other than the moves.  Note that I had to merge in some constructor bits from bug 314931 as well.

Comment 21

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Patch seems fine; Google Maps and GMail both work.

Comment 22

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I landed this on MOZILLA_1_8_BRANCH on the basis of a discussion I had a few weeks ago with jst; I couldn't find anyone else around to approve, and I needed it in to finish merging bug 336791.

Comment 23

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(Some after-the-fact review of the merging would still be good.)

Comment 24

[Christian :Biesinger (don't email me, ping me on IRC)]

This seems to have broken Camino:
http://tinderbox.mozilla.org/showlog.cgi?log=Camino/1149943620.4759.gz

Comment 25

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Ah, I missed the dependency on bug 335687; I'm not sure how easy it is to make that change without knowing the tools...

Comment 26

[Peter Van der Beken [:peterv]]

You also didn't pick up the allmakefiles.sh change and some of the packaging changes from bug 336244. Nothing major, but still nice to have.

Comment 27

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

> Ah, I missed the dependency on bug 335687; I'm not sure how easy it is to make
> that change without knowing the tools... 

I had Mano check in Camino project changes that should unbust maya on the 18branch next cycle.  (It's basically a 30sec fix, provided you're still running 10.3.9 and  Xcode 1.5--which is basically just me these days....)