Closed Bug 324946 Opened 16 years ago Closed 16 years ago

Error: linkNode has no properties Source file: chrome://browser/content/browser.js Line: 4816 for XLinks

Categories

(Firefox :: General, defect)

2.0 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 2 alpha1

People

(Reporter: Mook, Assigned: Gavin)

References

()

Details

(Keywords: fixed1.8.1, regression)

Attachments

(1 file)

(See URL)
Basically the loop simpilifies to:

while(linkNode) {
  linkNode = linkNode.parentNode;
} /* after loop, linkNode is null */
var baseURI = linkNode.baseURI; /* exception */

cc'ing jst because this came from his patch (rv 1.353, bug 249332) :)
This is actually a regression from bug 266932 - the loop used to break once it found a suitable node.
Attached patch patchSplinter Review
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #209883 - Flags: review?(mconnor)
OS: Windows XP → All
Hardware: PC → All
Version: unspecified → Trunk
wrapper is a leftover from the explicit XPCNativeWrapper days. How about removing that while you're here?
Keywords: regression
Summary: Error: linkNode has no properties Source file: chrome://browser/content/browser.js Line: 4816 → Error: linkNode has no properties Source file: chrome://browser/content/browser.js Line: 4816 for XLinks
(In reply to comment #3)
> wrapper is a leftover from the explicit XPCNativeWrapper days. How about
> removing that while you're here?

That makes the patch a lot harder to review, though. File a bug on that, assigned to me (or you, if you want it)?
(In reply to comment #4)
> That makes the patch a lot harder to review, though. File a bug on that,
> assigned to me (or you, if you want it)?

I only meant the "simple XLink" branch contained in the patch. Do you really want to do clean up all of browser.js?
(In reply to comment #5)
> I only meant the "simple XLink" branch contained in the patch. Do you really
> want to do clean up all of browser.js?

As far as I can tell, most uses of "wrapper" in browser.js are leftover from when there were wrappers. All the ones in contentAreaClick, for sure.
Attachment #209883 - Flags: review?(mconnor) → review+
mozilla/browser/base/content/browser.js; new revision: 1.557;
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3
fixed on the 1.8 branch in bug 266932
Keywords: fixed1.8.1
Target Milestone: Firefox 3 → Firefox 2 alpha1
Version: Trunk → 2.0 Branch
You need to log in before you can comment on or make changes to this bug.