325065 - browser/app/ needs to link against zlib in cairo-gtk2 builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Daniel C]

When building a cairo-gtk2 build, I get this error:

c++ -o firefox-bin -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -pedantic -fshort-wchar -pthread -pipe -DDEBUG -D_DEBUG -DDEBUG_djc -DTRACING -g -fno-inline nsBrowserApp.o -lpthread -L../../dist/bin -L../../dist/lib -lxul -lthebes -L../../dist/bin -lmozjs -L../../dist/bin -lxpcom -lxpcom_core -L../../dist/lib -lplds4 -lplc4 -lnspr4 -lpthread -ldl -lgtk-x11-2.0 -latk-1.0 -lgdk-x11-2.0 -lgdk_pixbuf-2.0 -lm -lpangocairo-1.0 -lpango-1.0 -lcairo -lgmodule-2.0 -ldl -lgobject-2.0 -lglib-2.0 -L../../dist/lib -lmozcairo -lmozlibpixman -lXrender -lfreetype -lfontconfig -lmozglitz -lmozglitzglx -lGL -lX11 -ldl -lm
/usr/lib/gcc-lib/i686-pc-linux-gnu/3.3.6/../../../../i686-pc-linux-gnu/bin/ld: warning: libmozz.so, needed by ../../dist/bin/libthebes.so, not found (try using -rpath or -rpath-link)
../../dist/bin/libthebes.so: undefined reference to `MOZ_Z_compress'
collect2: ld returned 1 exit status
gmake[5]: *** [firefox-bin] Error 1
gmake[5]: Leaving directory `browser/app'

This broke after a recent checkin to gfx/thebes/src/Makefile.in by [e-mail] which added $(ZLIB_LIBS)

> EXTRA_DSO_LDOPTS += $(MOZ_PANGO_LIBS) $(ZLIB_LIBS)

I have a patch which fixed this for me (after some help from biesi on IRC), however I've no idea if it's the right thing to do. I also don't know why the Linux Firefox-Cairo tinderbox isn't busted...

Comment 1

[Benjamin Smedberg]

Probably because the tinderbox is building static.

Could you try removing the ifdef at http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/config/autoconf.mk.in&rev=3.386&mark=159,161#150
and see if that fixes the problem?

Comment 2

[Daniel C]

Attachment: Add ZLIB_LIBS when building cairo-gtk2

Benjamin, this is what I used to fix the bug and it works. However, I don't know if it's the correct way to fix it. I'll test your suggestion shortly.

Comment 3

[Daniel C]

Attachment: Always fix link paths

This is Benjamin's suggestion, which I've just tested and can confirm that it works.

Comment 4

[Benjamin Smedberg]

Comment on attachment 210005 [details] [diff] [review]
Always fix link paths

r=me with the understanding that this may break the old tinderboxen still running OS X 10.2, see bug 299214 and dependency tree for more details.

Comment 5

[Daniel C]

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=&branchtype=match&dir=&file=mozilla%2Fbrowser%2Fapp%2FMakefile.in&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-02-01&maxdate=2006-02-03&cvsroot=%2Fcvsroot

[e-mail] just landed a similar change to attachment 209996 [details] [diff] [review]. Should this be reverted when attachment 210005 [details] [diff] [review] lands (after bug 299214 is fixed)?

Comment 6

[Stuart Parmenter]

probably

Comment 7

[Benjamin Smedberg]

This was checked in on trunk and 1.8 a while back.