325161 - support URI property on all result nodes

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

All results have an equivalent URI, whether that be the URI of the page, or the place: URI that generated them. As a result nsINavHistoryURIResultNode should be dispensed with, and the uri property brought down onto nsINavHistoryResultNode.

This will save the client js code a lot of work calling queriesToQueryString which will become fairly common if we store folder and query state as annotations keyed off place: uris.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

marking p1 since this blocks other feature dev. 

Comment 2

[Brett Wilson]

Attachment: Patch

This removes nsINavHistoryURIResultNode and moves the URI attribute onto nsINavHistoryResultNode. I also reordered parameters to put the URI in front of title in argument lists. It was in back of the common ones to reflect the fact that it wasn't always there.

Comment 3

[Annie Sullivan]

Comment on attachment 210950 [details] [diff] [review]
Patch

>-        bhist.removePage(this._uri(asURI(node).uri));
>+        bhist.removePage(this._uri(node,uri));

Shouldn't (node,uri) be (node.uri)?

Comment 4

[Brett Wilson]

On trunk and 1.8 branch.

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv