325175 - Says extension will install after firefox is restarted, but it doesn't happen.

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Matthew]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 (No IDN) Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 (No IDN) Firefox/1.5

I've recently downloaded a few extensions off of the firefox extension page. It says '_____ will be installed when firefox is restarted'. Closing the browser doesn't work. I have shut down my computer since then.

Reproducible: Always

Steps to Reproduce:
1.Download *imagebot* from mozilla.
2.Wait untill download is fully finished.
3.Exit browser/shut off computer.
4.Re-launch browser
5.Goto extensions
This is one of the extensions that ive tried, but ive tried others aswell.
Actual Results:  
Imagebot wont install, says imagebot will be installed when firefox is restarted

Expected Results:  
Installed, and properly worked.

I am using firefox version 1.5.

Comment 1

[Robert Strong (they/them - no direct email)]

This is works for me when installing imagebot.

Chances are you are experiencing one of the install bugs for the Extension Manager (e.g. bug 315245, bug 324314, and several others) which can prevent normal operations such as you describe. Can you zip up your profile's extensions directory along with the extensions.rdf, extensions.cache, and extensions.ini files that are located inside your profile's directory and either email the zip file to me or attach it to this bug? I suspect the resulting zip file will be larger than the maximum allowed for attachments so you will probably have to email them to me.
http://www.mozilla.org/support/firefox/profile

Comment 2

[Matthew]

Email sent. Im using a different theme, would that cause any problems?

Comment 3

[Matthew]

Ok, for some reason i cannot email them to you. I will seperatley add them.

Comment 4

[Matthew]

God, that wont work. Any suggestions?

Comment 5

[Robert Strong (they/them - no direct email)]

This appears to be similar (possibly a duplicate of) to Bug 324314.

Comment 6

[Robert Strong (they/them - no direct email)]

Attachment: patch

I'm seeing several cases where we have an error and then end up with an extension's directory that contains no files and there is a pending uninstall op for the same extension. We then end up trying to uninstall the same extension twice. This checks the StartupCache to see if there is a pending uninstall operation before adding a new one.

Comment 7

[Matthew]

Ok, ok. So what do i do with that patch?

Comment 8

[Robert Strong (they/them - no direct email)]

The patch is to fix the bug in the application so that future versions of the application won't have this bug. If you like I can create an updated file for you that includes several patches which would be required to all be present for this to fix this bug on your system. Or I can send you instructions on how to manually fix this on your system. Just send me an email with your preference.

Comment 9

[Robert Strong (they/them - no direct email)]

btw: comment #6 was for Benjamin who I asked to review this patch.

Comment 10

[Matthew]

Ok, i recived the update patch. But the extension problem is still there. I will try getting new extensions and see if i have any problems, if you dont hear from me, than it didnt work.

Comment 11

[Robert Strong (they/them - no direct email)]

(In reply to comment #10)
> Ok, i recived the update patch. But the extension problem is still there. I
> will try getting new extensions and see if i have any problems, if you dont
> hear from me, than it didnt work.
Ummm... I never sent an update to you and there is more than this one patch that will be needed. I should be able to send it this evening.

Comment 12

[Matthew]

Ohh, ok. I think i just downloaded the nightly build, a Firefox popup came and told me 1.5.0.1 is out now. So thats what i downloaded.

Comment 13

[Robert Strong (they/them - no direct email)]

Fixed on trunk

Comment 14

[Robert Strong (they/them - no direct email)]

Fixed on MOZILLA_1_8_BRANCH

Comment 15

[Robert Strong (they/them - no direct email)]

Comment on attachment 210305 [details] [diff] [review]
patch

I'd like to get this for 1.8.0.2 - it is a one liner that prevents a second uninstall operation for an extension that is already set to uninstall and it has already baked on the trunk and MOZILLA_1_8_BRANCH

Comment 16

[Dave Liebreich [:davel]]

Comment on attachment 210305 [details] [diff] [review]
patch

as per discussion in triage meeting 23-feb-2006

Comment 17

[Darin Fisher]

Rob, so this fix doesn't help someone who already has an extensions.cache with a redundant pending-uninstall entry, right?  It only helps prevent the bad state from happening in the first place, right?

Comment 18

[Robert Strong (they/them - no direct email)]

It might not under some conditions finish the uninstall but if there is a pending uninstall in the cache it should complete the uninstall during the next restart... for that matter other operations should complete as well. If there isn't a pending operations it should allow the user to perform any operation (e.g. upgrade or uninstall) against the extension that was prevented if this bug was experienced.

Comment 19

[Robert Strong (they/them - no direct email)]

bah... I had another bug on my brain though much of what I said applies here.

In this case if there is an uninstall entry in the cache this will prevent it being added to the pending operations a second time when the item's directory has been manually removed. It has the same requirements as a OP_NEEDS_INSTALL and a OP_NEEDS_UPGRADE hence the other two pre-existing checks alongside it.

Comment 20

[Robert Strong (they/them - no direct email)]

Just to make it clear what the problem is that this patch fixes... I have not seen a case where the extensions.cache contained multiple entries for the same addon. I have seen it contain an uninstall entry and the extension's directory no longer existing which will cause two uninstall pending operations. I can zip up the extensions directory along with the extensions.cache, extensions.ini, and extensions.rdf that I received if you'd like to test this.

Comment 21

[Daniel Veditz [:dveditz]]

Comment on attachment 210305 [details] [diff] [review]
patch

approved for 1.8.0 branch, a=dveditz for drivers

Comment 22

[Robert Strong (they/them - no direct email)]

Checked in to MOZILLA_1_8_0_BRANCH

Checking in mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in;
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v  <--  nsExtensionManager.js.in
new revision: 1.144.2.16.2.5; previous revision: 1.144.2.16.2.4

Comment 23

[Scott Field]

I'm still having a problem with Bug 325175, extension not installing after restart.
Mac OS X 10.3.9
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.2) Gecko/20060328 Firefox/1.5.0.2
It occurred with a clean profile with the first extension I tried to install.