If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

nsDocLoader broken on ALL 64 bit platforms.

VERIFIED FIXED in M15

Status

()

Core
Networking
P3
critical
VERIFIED FIXED
18 years ago
18 years ago

People

(Reporter: msw, Assigned: Frank Tang)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

18 years ago
nsDocLoader.cpp line 317:

nsDocLoaderImpl::GetContentViewerContainer(PRUint32 aDocumentID,
                                           nsIContentViewerContainer** aResult)
{
  nsISupports* base = (nsISupports*) aDocumentID;
  nsIDocument* doc;
  nsresult rv;

  rv = base->QueryInterface(kIDocumentIID, (void**)&doc);

----

You've just loaded a 32 bit value into a pointer and tried to dereference it. 
This breaks on 64 bit platforms including Compaq Alpha, UltraSPARC (if you're
building a 64 bit application), and ia64.
(Reporter)

Updated

18 years ago
Summary: Doc Loader broken on ALL 64 bit platforms. → nsDocLoader broken on ALL 64 bit platforms.

Updated

18 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 1

18 years ago
Setting target milestone to M15 and accepting bug.
Status: NEW → ASSIGNED
Target Milestone: --- → M15

Comment 2

18 years ago
This got fixed by Frank Tang before I could get to it.  Re-assigning to Frank 
so that he can mark it fixed.
Assignee: nisheeth → ftang
Status: ASSIGNED → NEW
(Assignee)

Comment 3

18 years ago
(from netherlands... ) this code have been fixed. Harishd need to change the 
part which cast void* into PRInt32 in parser to make it really work.
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
What's the bug on the parser so that we can track that?
(Reporter)

Comment 5

18 years ago
not fixed until
http://lxr.mozilla.org/seamonkey/search?string=%28nsISupports*%29aDocumentID
is clean
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 6

18 years ago
reassigning to myself. Have the change in hand...will land soon.
Assignee: ftang → harishd
Status: REOPENED → NEW

Comment 7

18 years ago
Okay, my part is done...  Back to ftang to verification. 

Note: verify with Apr 5th build.
Assignee: harishd → ftang
(Assignee)

Comment 8

18 years ago
It should be fixed now.
Status: NEW → RESOLVED
Last Resolved: 18 years ago18 years ago
Resolution: --- → FIXED
(Reporter)

Comment 9

18 years ago
Verified fixed here.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.