Open Bug 325240 Opened 19 years ago Updated 2 years ago

when opening a file from the download manager, provide an option to remove entry from the list if that file does not exist

Categories

(Toolkit :: Downloads API, enhancement)

enhancement

Tracking

()

People

(Reporter: kohei, Unassigned)

Details

Attachments

(4 obsolete files)

User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8) Gecko/20051111 Firefox/1.5 Build Identifier: undefined When you select "Open" on the entry and that file does not exist, Firefox just shows alert. Change this alert to confirm that user would like to remove the item from the list. Reproducible: Always Steps to Reproduce: 1. Download file to your desktop and delete it. 2. Select "Open" on the entry. Actual Results: Alert: Cannot Open %S %S does not exist. It may have been renamed, moved, or deleted since it was downloaded. Expected Results: Confirm: Cannot Open %S %S does not exist. It may have been renamed, moved, or deleted since it was downloaded. Would you like to remove this item from the list? The patch follows.
Attached patch patch v1 (obsolete) — Splinter Review
Attachment #210146 - Flags: ui-review?(mconnor)
Attachment #210146 - Flags: review?(mconnor)
Attached image Screenshot (obsolete) —
Assignee: nobody → bugzilla1
Status: UNCONFIRMED → NEW
Ever confirmed: true
Status: NEW → ASSIGNED
Whiteboard: [needs review mconnor]
Comment on attachment 210146 [details] [diff] [review] patch v1 I generally don't like OK/Cancel buttons for dialogs like this. I'd much rather see something like the following (noting that I haven't thought in depth about this yet) |-------------------------------------------------------------| | Cannot open foo.exe | |-------------------------------------------------------------| | foo.exe does not exist. It may have been renamed, moved, or | | deleted since it was downloaded. Would you like to remove | | this item from the list? | | | | [Cancel] [Remove Item] | |-------------------------------------------------------------|
Attachment #210146 - Flags: ui-review?(mconnor)
Attachment #210146 - Flags: ui-review-
Attachment #210146 - Flags: review?(mconnor)
Is there any way to call the Windows service that looks for the file on the user's HDD? The "cancel" use case seems really weak, and I'd rather that we provide only options that actually further the user's desired task (in this case, finding that file). This would make the options: .-------------------------------------------------------------, | Cannot open foo.exe | |-------------------------------------------------------------| | foo.exe does not exist. It may have been renamed, moved, or | | deleted since it was downloaded. Would you like to remove | | this item from the list? | | | | [Find File] [Remove Item] | '-------------------------------------------------------------' If there's no way to do this, then mconnor's solution gets my recommendation as well.
We should implement support for that, definitely (more work, but useful)
Whiteboard: [needs review mconnor]
I think that Mike Beltzner's idea is not scope of this bug. Because I think that it is hard work. Should we fix comment 3 first, and file a new bug for comment 4?
Attached patch patch v2 (obsolete) — Splinter Review
(In reply to comment #3) True, OK/Cancel button is not good in this case. I adopted "Remove item" button. Find File feature is interesting, but discuss it in another bug.
Attachment #210146 - Attachment is obsolete: true
Attached image updated screenshot (obsolete) —
Attachment #210147 - Attachment is obsolete: true
Comment on attachment 210469 [details] updated screenshot small nit: the default action should probably be cancel, since it's the non-destructive option, and the user might want to get at the properties to find where they'd downloaded the file if it has indeed been accidentally deleted. I'll open a bug for the [Find File] issue I raised in comment 4 and cc everyone from here.
Attachment #210469 - Flags: ui-review+
Summary: Option to remove entry from the list if that file does not exist → when opening a file from the download manager, provide an option to remove entry from the list if that file does not exist
Is this available for Firefox 3 or trunk? Now download manager has only "Clear List" button. I think this function is suitable for some extension.
Product: Firefox → Toolkit
Attachment #210468 - Attachment is obsolete: true
Attachment #210469 - Attachment is obsolete: true
Still relevant, but I can no longer handle this.
Assignee: kohei.yoshino → nobody
Status: ASSIGNED → NEW
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: