Closed
Bug 325250
Opened 19 years ago
Closed 19 years ago
Some places notifications hang browser
Categories
(Firefox :: Bookmarks & History, defect, P1)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox 2 alpha1
People
(Reporter: brettw, Assigned: brettw)
References
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
|
1.63 KB,
patch
|
bryner
:
review+
|
Details | Diff | Splinter Review |
The problem is that some notifications like ClearHistory cause a new node and corresponding observer to be created. We therefore get into an infinite loop of notifying observers and having them create a new observer.
|
Assignee | |
Updated•19 years ago
|
Severity: normal → blocker
Priority: -- → P1
Target Milestone: --- → Firefox 2 alpha1
|
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #210168 -
Flags: review?(bryner)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 210168 [details] [diff] [review]
Patch
Looks good. You should move the comment about creating a copy up, so that it applies to both macros.
Attachment #210168 -
Flags: review?(bryner) → review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
On trunk and branch.
|
||
Comment 4•16 years ago
|
||
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".
In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body contains places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.
Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.
Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•