325251 - In labels for controls we don't call |formatAccessKey()| when value is set

Status: NEW

(SeaMonkey :: UI Design, defect)

Description

[jag (Peter Annema)]

This means that for such labels you're forced to set |value| before you set |accessKey| to trigger the formatting. In nsTextBoxFrame.cpp it triggers on both.

Comment 1

[[e-mail]]

Actually, I faked out nsTextBoxFrame.cpp - if you have alwaysappendaccesskey set to true, and set a label to Cancel, then its access key to X, then the label to Cancel (X), then Cancel (X) is displayed, but if you set a label to Cancel (X), then the access key to X, then Cancel (X) (X) is displayed.

Comment 2

[[e-mail]]

Attachment: Fix over-optimization

The code tries to optimize the attribute change but compares the wrong title.

Comment 3

[jag (Peter Annema)]

Attachment: This is the fix I had for radio buttons and checkboxes.

This is my "quickly hacked together without thinking _too_ much" patch from right before I filed this bug. If check boxes and radio buttons aren't covered by Neil's patch I can spend some time cleaning this up.

Comment 4

[[e-mail]]

Comment on attachment 211309 [details] [diff] [review]
This is the fix I had for radio buttons and checkboxes.

This is just cut & paste & search & replace of previously reviewed code, right ;-)