325264 - can't change newsgroups, doc links, or component description

Status: RESOLVED FIXED

(Webtools Graveyard :: Despot, defect, P2)

Description

[timeless]

i've tried to change newsgroups, both as a peer and as an owner, it isn't working.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I'm unable to change newsgroups, doc links, or component description in despot.

This is a serious regression.

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

The patch to bug 313041 seems the most suspicious as a potential cause of this bug.  It changed the line where the description, branchid, state, newsgroups, and doclinks were set; I'm not sure if anyone's tested changing branchid or state recently, but the other three are known to be broken and most other fields are known to work.

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

-    Query("update partitions set description=" .
-          $::db->quote($F::description) .
-          ", branchid=$branchid, state='$F::state', newsgroups=" .
-          $::db->quote($F::newsgroups) .
-          ", doclinks=" .
-          $::db->quote($F::doclinks) .
-          " where id=$F::partitionid");
+    $::db->do("UPDATE partitions SET description = ?, " .
+                                    "branchid = ?, " .
+                                    "state = ?, " .
+                                    "newsgroups = ?, " .
+                                    "doclinks = ?, " .
+              "WHERE id = ?",
+        undef, $F::description, $branchid, $F::state, $F::newsgroups, $F::doclinks, $F::partitionid);

Could the problem be the comma added before "WHERE" in the above change from bug 313041?

Comment 4

[Dave Miller [:justdave]]

Attachment: Patch v1

(In reply to comment #3)
> Could the problem be the comma added before "WHERE" in the above change from
> bug 313041?

Almost positively.  If that's not the cause of this specific problem, it's still wrong.  Based on the logs, I'm betting this is it.  I've already pushed this patch live, give it a shot and see if it works.

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 219980 [details] [diff] [review]
Patch v1

yep, it works.  I'm not really a qualified reviewer for this language, but it is a one character patch to revert it back to the way it used to be...

Comment 6

[Dave Miller [:justdave]]

Checking in despot.cgi;
/cvsroot/mozilla/webtools/despot/despot.cgi,v  <--  despot.cgi
new revision: 1.36; previous revision: 1.35
done