Don't unnecessarily load favicon

RESOLVED FIXED in Firefox 2 beta1



Bookmarks & History
12 years ago
8 years ago


(Reporter: Brett Wilson, Assigned: Brett Wilson)


Firefox 2 beta1

Firefox Tracking Flags

(Not tracked)



(1 attachment)

2.30 KB, patch
Ben Goodger (use ben at mozilla dot org for email)
: review+
Details | Diff | Splinter Review


12 years ago
The favicon service loads favicons way more than it should. It is currently hooked in the same way the URL bar favicon thingy is. The result is that every time you change tabs, it will reload the favicon (probably from cache), save it in the DB, and fire a bunch of observers, which will redraw trees, update the toolbar, etc.

We currently do it in browser.js:PageProxySetIcon. We should hook up favicon notifications further upstream.

Further, it would be nice to have some policy where we don't keep having to reload the favicon data if we've loaded it recently for the same page or another page with the same favicon.


12 years ago
Priority: -- → P2
Target Milestone: --- → Firefox 2 beta1


12 years ago
Assignee: nobody → brettw

Comment 1

12 years ago
Created attachment 213637 [details] [diff] [review]

This patch re-enables favicon setting which was broken by the browser shim disband. It also moves the code to the proper place so that it only gets called when the browser gets a new favicon, and not everytime it changes in the URL bar as before (like even when you switched tabs).
Attachment #213637 - Flags: review?(bugs)

Comment 3

12 years ago
On branch and trunk
Last Resolved: 12 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
This patch wasn't landed on the 1.8 branch.
Keywords: fixed1.8.1

Comment 5

12 years ago
On branch for real now
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.