325292 - col visibility:collapse shows cells in printing second page of a table

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[Jeff]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8) Gecko/20051111 Firefox/1.5

Printing a table with 
<colgroup>
  <col></col>
  <col style='visibility:collapse'></col>
  <col></col>
</colgroup>
that goes over to a second page shows blank cells rather than suppressing them.  The first page is right. True in print preview as well.  See a simple sample at the test URL.

Reproducible: Always

Steps to Reproduce:
1.Load test page
2.File | Print Preview
3.Scroll to second or third page

Actual Results:  
data rows of : <tr><td>Show</td><td>Don't Show</td><td>do</td></tr>
on page one show: Show | do
on page two show: Show |____| do

Expected Results:  
all lines on page two to look like on page 1

I haven't found a work around, tried width:0px and the like, no good.

Comment 1

[Bernd]

Attachment: testcase

Comment 2

[Bernd]

I guess http://lxr.mozilla.org/seamonkey/ident?i=AdjustForCollapsingCols is not called on the second page.

Comment 3

[Jeff]

Attachment: Worse with <thead>

The problem appears worse with a <thead> section, the supposedly suppressed column's header is displayed on page 2 and later.

Comment 5

[Daniel Holbert [:dholbert]]

Confirmed with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b1pre) Gecko/20080903020504 Minefield/3.1b1pre
Platform --> All/All

Comment 6

[Bernd]

Attachment: incomplete patch

this fixes the not calling on the second page however the width of the table on the second page is still computed wrong.

Comment 7

[Bernd]

Attachment: patch

The patch does three things
- it places the code from bug 492661 at a much more efficient place
- it moves all table column related stuff to the first inflow, where it belongs
- it puts the flag NeedToCollapse on the first inflow too.

Comment 8

[Bernd]

I pushed http://hg.mozilla.org/mozilla-central/rev/a5b5a8741932

the reftest fails under linux I opened bug 499578 pushed a possible fix to the try server.

Comment 9

[Bernd]

I pushed a modification to the testcase http://hg.mozilla.org/mozilla-central/rev/396f9743df7b that fixed the linux failure