325305 - minor memory leak in CERT_FindCertByNameString

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P1)

Description

[Alexei Volkov]

CERT_FindCertByNameString leaks memory in case when encoding is unsuccessful.

Comment 1

[Alexei Volkov]

"name" should be destroyed by CERT_DestroyName(name) before exiting the function

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Alexei, thanks for finding these bugs.  
Since you've done the hard work (finding the bugs), 
please attach patches to fix them.

Comment 3

[Alexei Volkov]

Attachment: patch

Comment 4

[Wan-Teh Chang]

Comment on attachment 210409 [details] [diff] [review]
patch

Alexei, with this patch, you also need to initialize 'name' to NULL.

An alternative fix is to simply move the
CERT_DestroyName(name) call up so that it is
right below the SEC_ASN1EncodeItem call (the
last use of 'name').

Comment 5

[Alexei Volkov]

Attachment: patch v2

changing patch to fix the bug with one line fix as suggested by Wan-Teh.

Comment 6

[Wan-Teh Chang]

Comment on attachment 210421 [details] [diff] [review]
patch v2

r=wtc.

Comment 7

[Alexei Volkov]

Attachment: alternative, less risky way to fix it.

Comment 8

[Wan-Teh Chang]

Comment on attachment 210424 [details] [diff] [review]
alternative, less risky way to fix it.

r=wtc.

Comment 9

[Alexei Volkov]

#3 patch was integrated with

Checking in certhigh.c;
/cvsroot/mozilla/security/nss/lib/certhigh/certhigh.c,v  <--  certhigh.c
new revision: 1.35; previous revision: 1.34

Comment 10

[Julien Pierre]

Alexei,

Your checkin was to the tip which is 3.12. The bug is currently targeted for 3.11.1. If you want it to go in that release, then you need to make an additional checkin to NSS_LIBPKIX_BRANCH .

Comment 11

[Julien Pierre]

Of course I meant the NSS_3_11_BRANCH, not libpkix ;).

Comment 12

[Alexei Volkov]

Got it in for 3.11

Checking in certhigh.c;
/cvsroot/mozilla/security/nss/lib/certhigh/certhigh.c,v  <--  certhigh.c
new revision: 1.34.2.1; previous revision: 1.34