325350 - Places build fails at nsBookmarksFeedHandler.cpp

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Dave Townsend [:mossop]]

Bug 323958 changed the parser method signatures but neglected to fix the call from the places bookmarks feed handler.

Patch coming up.

Comment 1

[Dave Townsend [:mossop]]

Attachment: change parse call

This fixes the method call. Not sure who to get to review this.

Comment 2

[Mike Connor [:mconnor]]

Comment on attachment 210255 [details] [diff] [review]
change parse call

Brett, can you review/land this for Dave?

Comment 3

[Dave Townsend [:mossop]]

That should have been from bug 323958

Comment 4

[Brett Wilson]

Comment on attachment 210255 [details] [diff] [review]
change parse call

This is just on trunk, right? I'm going to put #ifndef MOZILLA_1_8_BRANCH around it. We keep places code in sync between branch and trunk.

Comment 5

[Brett Wilson]

On branch and trunk (conditionally compiled).

Comment 6

[Dave Townsend [:mossop]]

The patch in bug 323958 did hit one file in places and that might need to have ifdefs around it to stop it hitting the branch.

mozilla/browser/components/places/src/nsBookmarksHTML.cpp

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

Yeah, you probably want to fix that too. Sorry, I didn't realize that I'd touched places.

Comment 8

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv