325361 - When an event is scheduled at midnight of a given day of the month, one email is sent *each* hour of that day

Status: RESOLVED FIXED

(Bugzilla :: Whining, defect)

Description

[Frédéric Buclin]

The problem is that editwhines.cgi get the time of the day as, see line 224:

my $time          = $cgi->param("time_$sid") || '';

And so an empty string is added into the whine_schedules table if the event is scheduled at midnight, because $cgi->param("time_$sid") = 0. And so 0 is converted to ''. From what I see, this is a regression from bug 298510.

But whine.pl does this check at line 573:

    if (($run_today) && ($run_time !~ /^\d+$/)) {
        # The default of 60 catches any bad value
        my $minute_interval = 60;

As $run_time is "" instead of 0, an time interval of 60 minutes is set, meaning that an email will be sent *each* hour, instead of once per month. I just have bitten by this on landfill (already 13 emails today :( ).

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

The patch applies on both 2.20 and tip.

Comment 2

[Frédéric Buclin]

tip:

Checking in editwhines.cgi;
/cvsroot/mozilla/webtools/bugzilla/editwhines.cgi,v  <--  editwhines.cgi
new revision: 1.13; previous revision: 1.12
done
Checking in whine.pl;
/cvsroot/mozilla/webtools/bugzilla/whine.pl,v  <--  whine.pl
new revision: 1.21; previous revision: 1.20
done


2.20:

Checking in editwhines.cgi;
/cvsroot/mozilla/webtools/bugzilla/editwhines.cgi,v  <--  editwhines.cgi
new revision: 1.8.2.2; previous revision: 1.8.2.1
done
Checking in whine.pl;
/cvsroot/mozilla/webtools/bugzilla/whine.pl,v  <--  whine.pl
new revision: 1.13.2.4; previous revision: 1.13.2.3
done