325381 - nsWebBrowserPersist::OnWalkDOMNode missing early return?

Status: RESOLVED FIXED

(Core :: DOM: Serializers, defect)

Description

[Kathleen :Brade]

I was looking at nsWebBrowserPersist::OnWalkDOMNode today:

nsresult nsWebBrowserPersist::OnWalkDOMNode(nsIDOMNode *aNode)
{
  // Fixup xml-stylesheet processing instructions
  nsCOMPtr<nsIDOMProcessingInstruction> nodeAsPI = do_QueryInterface(aNode);
  if (nodeAsPI)
  {
    nsAutoString target;
    nodeAsPI->GetTarget(target);
    if (target.EqualsLiteral("xml-stylesheet"))
    {
      nsAutoString href;
      GetXMLStyleSheetLink(nodeAsPI, href);
      if (!href.IsEmpty())
      {
        StoreURI(NS_ConvertUCS2toUTF8(href).get());
      }
    }
  }

It seems like there should be a return NS_OK; after the StoreURI call as there is in the code below.  Is there a reason we don't return early?

Comment 1

[Ryan Jones-Ward [:sciguyryan]]

Attachment: Patch v1

Patch v1

It should be fine to return any time inside the |nodeAsPI| node as far as I can see.

Comment 2

[Kenneth Herron]

Patch v1 checked in. Clearing checkin-needed status.