Closed Bug 325400 Opened 15 years ago Closed 15 years ago

client.mk fast-update broken under Cygwin

Categories

(Firefox Build System :: General, defect)

x86
Windows XP
defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: wicked, Assigned: wicked)

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

Fast-update target in client.mk fails to detect any changes when run under Cygwin. This is because the config/fast-update.pl perl script doesn't sanitize input from CVS/Repository file correctly but leaves CR because it expects only LF. Cygwin is installed using "DOS" style line endings suggested in Windows Build Requirements (http://developer.mozilla.org/en/docs/Windows_Build_Prerequisites).
Assignee: nobody → wicked
Status: UNCONFIRMED → ASSIGNED
Attachment #210314 - Flags: review?
Comment on attachment 210314 [details] [diff] [review]
Correctly remove any CRLF in the rootdir, V1

To get somebody to land this, ask on irc.mozilla.org #developers
Attachment #210314 - Flags: review? → review+
mozilla/config/fast-update.pl; new revision: 1.12; previous revision: 1.11
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Version: 1.8 Branch → Trunk
Attachment #210314 - Flags: branch-1.8.1?(benjamin)
Can we verify it's fixed on trunk before I go approving for braches?

(God do I think fast-update is pointless... we've got decent CVS servers nowadays).
Yeah, fast-update is SO pointless. I mean it only shaves 80% of the time off an update. :P  (5m or less, compared to 25m+ for a normal update)
Comment on attachment 210314 [details] [diff] [review]
Correctly remove any CRLF in the rootdir, V1

Please re-requeest branch-1.8.1 when this has been verified on trunk.
Attachment #210314 - Flags: branch-1.8.1?(benjamin)
(In reply to comment #6)
> Please re-requeest branch-1.8.1 when this has been verified on trunk.

So, who's responsible doing this verification? Can I do it or do you need some official QA person to ok this? FWIW, my patch was specifically made against 1.8.1 branch and I'm using this patch there myself.
I can verify that the patch here makes it work (I've had my own slightly different version of the patch in my tree for YEARS and this patch works just as well as mine :) ).
Status: RESOLVED → VERIFIED
Comment on attachment 210314 [details] [diff] [review]
Correctly remove any CRLF in the rootdir, V1

Re-requesting approval-branch-1.8.1 as instructed.
Attachment #210314 - Flags: approval-branch-1.8.1?(benjamin)
Attachment #210314 - Flags: approval-branch-1.8.1?(benjamin) → approval-branch-1.8.1+
mozilla/config/fast-update.pl 	1.11.70.1
Keywords: fixed1.8.1
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.