325450 - nsGREGlue check of GRE_HOME needs to add "/libxpcom.so"

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GRE Core, defect, P2)

Description

[Benjamin Smedberg]

nsGREGlue has a check for GRE_HOME (which should by tradition be a directory path), but the function should return a patch with the XPCOM DLL path.

Comment 1

[Benjamin Smedberg]

Attachment: Fix GRE_HOME, rev. 1

Comment 2

[Darin Fisher]

Comment on attachment 216552 [details] [diff] [review]
Fix GRE_HOME, rev. 1

>Index: xpcom/glue/nsGREGlue.cpp

>+    char p[MAXPATHLEN];
>+    snprintf(p, sizeof(p), "%s" XPCOM_FILE_PATH_SEPARATOR XPCOM_DLL, env);
>+    p[sizeof(p)] = '\0';

This is writing a null byte beyond the end of the array.  snprintf promises
to null terminate |p| or upon failure it will leave |p| unmodified.  Perhaps
you should initialize p[0] to '\0' then.

r=darin w/ that fixed

Comment 3

[Benjamin Smedberg]

Fixed on trunk. I'd like to fix this on the 1.8 branch as well, but not 1.8.0 as it is in a bizarre way an API that should remain stable.

Comment 4

[Darin Fisher]

Comment on attachment 216552 [details] [diff] [review]
Fix GRE_HOME, rev. 1

a=darin

Comment 5

[Benjamin Smedberg]

Fixed on 1.8 branch.