Closed Bug 325507 Opened 19 years ago Closed 19 years ago

Replace nsISupportsArray with nsCOMArray in nsPluginInstanceOwner::EnsureCachedAttrParamArrays

Categories

(Core :: Layout, defect)

1.8 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bzbarsky, Unassigned)

Details

Attachments

(1 file, 1 obsolete file)

The current code sets up an nsISupportsArray of nodes, then does QIing on getting them back. I think this would be simpler with an nsCOMArray<nsIDOMElement> instead...
Attached patch patch (obsolete) — Splinter Review
So like this, I guess. It compiles. Not sure how to test this code, though. This is a trunk patch, you want a 1.8 branch patch? I could make that one tomorrow.
Comment on attachment 210466 [details] [diff] [review] patch >Index: layout/generic/nsObjectFrame.cpp >+ nsCOMPtr<nsIDOMElement> param = ourParams.ObjectAt(idx); Can just use nsIDOMElement* param here, I think. With that, r+sr=bzbarsky
Attachment #210466 - Flags: superreview+
Attachment #210466 - Flags: review+
Attached patch patch2Splinter Review
Updated to comments. Haven't tested yet if this compiles.
Attachment #210466 - Attachment is obsolete: true
Ok, patch2 compiles just fine, so I checked that one in. Checking in layout/generic/nsObjectFrame.cpp; /cvsroot/mozilla/layout/generic/nsObjectFrame.cpp,v <-- nsObjectFrame.cpp new revision: 1.548; previous revision: 1.547 done
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: