325537 - Shouldn't be building stacktrace stuff in releases

Status: RESOLVED WONTFIX

(Core :: XPCOM, defect)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

So, we shouldn't be building the code in https://bugzilla.mozilla.org/show_bug.cgi?id=323853 into releases to begin with...  This seems to me that its useful for debug and tools, but not necessarily releases.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Specifically, it seems to me that if neither CRAWL_STACK_ON_SIGSEGV (see nsSigHandlers.cpp) nor NS_BUILD_REFCNT_LOGGING is defined we shouldn't be building nsStackFrameUnix...  (and we should probably not be building the body of nsTraceRefcntImpl::InitTraceLog when NS_BUILD_REFCNT_LOGGING is not defined either).

Comment 2

[Benjamin Smedberg]

IMO this is wontfix... we want nsITraceRefcnt to continue working in release builds because it can be useful for extension authors who build debug on top of a release firefox (and see bug 325229).

Comment 3

[Benjamin Smedberg]

And FWIW I do have plans to ship the XULRunner symbols with the SDK, so that backtraces are meaningful. And the nsDebug code also calls WalkTheStack when XPCOM_DEBUG_BREAK=stack

Comment 4

[Doug Turner (:dougt)]

what is the savings with it off?

Comment 5

[Boris Zbarsky [:bzbarsky]]

Ah, ok.  I didn't realize that we had an interface for this.  ;)