325660 - calendar XPI needs main-window overlay to explicitly start alarm service

Status: RESOLVED WONTFIX

(Calendar :: Sunbird Only, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

As a result of the changes made in bug 325476, the alarm service is no longer being started in calendar.xpi.  An overlay to the main application window needs to be added that explicitly starts the service.

Comment 1

[Joey Minta]

*** Bug 328767 has been marked as a duplicate of this bug. ***

Comment 2

[Peter Weilbacher]

Attachment: add alarm init to overlay

This isn't really a killer, a very similar problem exists with MailNews, too, where you have to open that window once to activate mailbox checks.

But I looked at this and this patch works, I tested with SeaMonkey. Unfortunately, it also slows down the startup time by quite a bit because initializing the alarm service obviously means that it checks each event before continuing and that all takes place before any windows are painted, so it's pretty annoying.

Btw, are the files calendar\resources\content\calExtOverlay.* still in use for Firefox? Then the same lines would need to be added there.

Comment 3

[Peter Weilbacher]

As Joey remarked in the newsgroup timezone=-1 was not very clever, but it doesn't have any serious results AFAICS.

But there doesn't seem to be an interface that lets me access calendarDefaultTimezone() or at least guessSystemTimezone() to do this correctly or am I blind?

Comment 4

[Joey Minta]

(In reply to comment #3)
> As Joey remarked in the newsgroup timezone=-1 was not very clever, but it
> doesn't have any serious results AFAICS.
It should, if there are any items with alarms actually in the calendar:

js> var cdt = Components.classes["@mozilla.org/calendar/datetime;1"].createInstance(Components.interfaces.calIDateTime);
js> cdt.jsDate = new Date();
Sun Mar 26 2006 12:33:45 GMT-0500 (CDT)
js> cdt.getInTimezone(-1);
uncaught exception: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [calIDateTime.getInTimezone]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: typein :: <TOP_LEVEL> :: line 3"  data: no]


> 
> But there doesn't seem to be an interface that lets me access
> calendarDefaultTimezone() or at least guessSystemTimezone() to do this
> correctly or am I blind?
> 
You need to include chrome://calendar/content/calendarUtils.js, then the function will be available.

Comment 5

[Peter Weilbacher]

Attachment: With calenderUtils.js included...

Oh yes, including works, too, and is better than cheating. Stupid me! :-)

Let me figure out over the next days if I find a way to not make it block the startup while loading the alarms.

Comment 6

[Peter Weilbacher]

Attachment: Asynchronous alarm init

Now that the calendar extension is announced to be dead any more work is probably wasted. But as I had already done this new patch I can as well upload it.

I haven't actually timed if synchronous or this new asynchronous alarm init is faster to display the main window, so I leave both active...

Comment 7

[Simon Paquet [:sipaq]]

calendar.xpi is dead