Closed Bug 325700 Opened 20 years ago Closed 20 years ago

remove unused variables and unused carbon event handling from Cocoa menus

Categories

(Core :: Widget: Cocoa, defect)

Product:
Core
Component:
Widget: Cocoa
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jaas, Assigned: jaas)

Details

Attachments

(1 file, 1 obsolete file)

fix v1.1
6.14 KB, patch
mark
: review+
mikepinkerton
: superreview+
Details | Diff | Splinter Review
Attached patch fix v1.0 (obsolete) — — Splinter Review
Attachment #210560 - Flags: review?(mark)
Comment on attachment 210560 [details] [diff] [review] fix v1.0 I was about to hit the r+ button, but I looked into this and found that nobody even uses GetTarget. Let's just take it out of nsIMenuItem and remove the bogus implementations from both Carbon and Cocoa widgets. Nobody else extends nsIMenuItem.
Sounds good.
Attached patch fix v1.1 — — Splinter Review
Attachment #210560 - Attachment is obsolete: true
Attachment #210886 - Flags: review?(mark)
Attachment #210560 - Flags: review?(mark)
Comment on attachment 210886 [details] [diff] [review] fix v1.1 we &heart; cleanup
Attachment #210886 - Flags: review?(mark) → review+
Attachment #210886 - Flags: superreview?(mikepinkerton)
sr from pinkerton on IRC Fixed on trunk.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Comment on attachment 210886 [details] [diff] [review] fix v1.1 sr=pink
Attachment #210886 - Flags: superreview?(mikepinkerton) → superreview+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: