325795 - Crash in [@ nsTreeContentView::GetCell] if tree.view.getCellValue(null,null);

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Willy also]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20051110 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20051110 Firefox/1.6a1

Firefox crashes if tree onselect and get value with tree.view.getCellValue(null,null);

Reproducible: Always

Comment 1

[Willy also]

Attachment: crash if tree.view.getCellValue(null,null)

Comment 2

[Willy also]

Comment on attachment 210641 [details]
crash if tree.view.getCellValue(null,null)

open attachment and select a treeitem

Comment 3

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Talkback ID: TB14719081K

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Only the second arg needs to be null, right? GetCellValue doesn't null check aCol before passing it to GetCell.

Comment 5

[Willy also]

(In reply to comment #4)
> Only the second arg needs to be null, right? GetCellValue doesn't null check
> aCol before passing it to GetCell.
> 
That's right

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Trunk stack

Comment 7

[timeless]

Attachment: ensure args

Comment 8

[Martijn Wargers (dead)]

Timeless, what's the status of this bug?
Was the patch checked in? Can this bug be closed then?

Comment 9

[timeless]

Comment on attachment 216360 [details] [diff] [review]
ensure args

mozilla/layout/xul/base/src/tree/src/nsTreeContentView.cpp 	1.54

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using build 2006-05-07-06 of SeaMonkey trunk on Windows XP with https://bugzilla.mozilla.org/attachment.cgi?id=210641&action=view

No crash.

Comment 11

[Willy also]

(In reply to comment #10)
> Verified FIXED using build 2006-05-07-06 of SeaMonkey trunk on Windows XP with
> https://bugzilla.mozilla.org/attachment.cgi?id=210641&action=view
> 
> No crash.
> 

Test with:

Mozilla/5.0 (Windows; U; Windows NT 5.0;
en-US; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1

nothing changed, still crashes