325844 - [10.3] Hook up Undo in the homepage field, history

Status: RESOLVED WONTFIX

(Camino Graveyard :: Preferences, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

It's fairly easy to accidentally open the prefs and accidentally blank/replace the homepage field, since the field is automatically focused and the contents are selected, and a stray keypress on/along with/after cmd-, is pretty easy to cause.  Some of us seem to do this frequently :-(

Though not with the same consequences, the same problem is present in the History pane's field for number of days.

Esc should, like in the location bar, cancel the edit as long as you haven't hit return.  

On 10.4, Undo seems magically enabled for this field, but not on 10.3 (why?); regardless, Esc should also work, and it doesn't.

When/if bug 285531 is implemented, Esc should cancel the edit and close the prefs.

Comment 1

[Wevah (Nate Weaver)]

I think we should just make undo work properly in those fields under 10.3.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Wevah: i'm noot really sure how to
Wevah: unless calling setAllowsUndo:YES on the field editor will do it
Wevah: we could probably just call that in controlTextDidBeginEditing: or something

Leaving this a 1.1 for now since there may be a simple fix for us; Ian will investigate further.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Mass un-setting milestone per 1.6 roadmap.

Filter on RemoveRedonkulousBuglist to remove bugspam.

Developers: if you have a patch in hand for one of these bugs, you may pull the bug back to 1.6 *at that point*.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Bye-bye 10.3.