Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Some files are preprocessed unnecessarily

RESOLVED FIXED in Firefox 17

Status

()

Firefox
General
--
minor
RESOLVED FIXED
12 years ago
5 years ago

People

(Reporter: Gavin, Assigned: andreshm)

Tracking

Trunk
Firefox 17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 6 obsolete attachments)

This increases build time and should be fixed. I'll do CSS files first, since they're blocking the branch patch for bug 305767.
Status: NEW → ASSIGNED
Created attachment 210706 [details] [diff] [review]
CSS files (checked in)
Attachment #210706 - Flags: review?(mconnor)
Whiteboard: [patch-r?]

Updated

12 years ago
Attachment #210706 - Flags: review?(mconnor)
Attachment #210706 - Flags: review+
Attachment #210706 - Flags: approval-branch-1.8.1+
Target Milestone: Firefox 2 alpha1 → Firefox 2
Comment on attachment 210706 [details] [diff] [review]
CSS files (checked in)

checked in, branch and trunk. leaving open for other possible files.
Attachment #210706 - Attachment description: CSS files → CSS files (checked in)
Priority: -- → P5
Target Milestone: Firefox 2 → ---
Whiteboard: [patch-r?]
Target Milestone: --- → Future
Assignee: gavin.sharp → nobody
Status: ASSIGNED → NEW
Priority: P5 → --
Target Milestone: Future → ---
Created attachment 644063 [details] [diff] [review]
fix files in browser/base

I did a quick pass and tried to fix the files in browser/base. I haven't looked over this carefully, it may have bugs.
Attachment #210706 - Attachment is obsolete: true
(Assignee)

Comment 4

5 years ago
I'll continue with this.
Assignee: nobody → andres
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 5

5 years ago
Question, the %if 0 or #if 0 directives are required for some reason or can be removed?
It depends on the specific use. But I don't think you should worry about those to start - let's just get the ones that the preprocessor warns about to begin with.
(Assignee)

Comment 7

5 years ago
Created attachment 651450 [details] [diff] [review]
Patch v1 browser/base

browser/base fixes.
Attachment #644063 - Attachment is obsolete: true
Attachment #651450 - Flags: review?(gavin.sharp)
(Assignee)

Comment 8

5 years ago
Created attachment 651451 [details] [diff] [review]
Patch v1 browser/components

browser/components fixes.
Attachment #651451 - Flags: review?(gavin.sharp)
(Assignee)

Comment 9

5 years ago
Created attachment 651452 [details] [diff] [review]
Patch v1 browser/locales

browser/locales fixes.
Attachment #651452 - Flags: review?(gavin.sharp)
(Assignee)

Comment 10

5 years ago
Created attachment 651453 [details] [diff] [review]
Patch v1 browser/themes

browser/themes fixes.
Attachment #651453 - Flags: review?(gavin.sharp)
(Assignee)

Comment 11

5 years ago
I'll continue with toolkit files
(Assignee)

Comment 12

5 years ago
Toolkit files are fine. Any other I should check?
We want to fix all the warnings that show up during a mozilla-central firefox build, but I imagine there may be a long tail. Don't need to tackle that in this bug, might be good to file a followup.
Attachment #651450 - Flags: review?(gavin.sharp) → review+
Attachment #651451 - Flags: review?(gavin.sharp) → review+
Attachment #651452 - Flags: review?(gavin.sharp) → review+
Attachment #651453 - Flags: review?(gavin.sharp) → review+
Created attachment 651795 [details] [diff] [review]
rolled up browser/ patch

Thanks for fixing this, Andres!
Attachment #651450 - Attachment is obsolete: true
Attachment #651451 - Attachment is obsolete: true
Attachment #651452 - Attachment is obsolete: true
Attachment #651453 - Attachment is obsolete: true
Attachment #651795 - Flags: review+
(Assignee)

Comment 15

5 years ago
Thank you, do we need a try run for this?
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d0ce062c403
Target Milestone: --- → Firefox 17
Nope! :)
https://hg.mozilla.org/mozilla-central/rev/6d0ce062c403
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Duplicate of this bug: 778621
You need to log in before you can comment on or make changes to this bug.