This increases build time and should be fixed. I'll do CSS files first, since they're blocking the branch patch for bug 305767.
Created attachment 210706 [details] [diff] [review] CSS files (checked in)
Comment on attachment 210706 [details] [diff] [review] CSS files (checked in) checked in, branch and trunk. leaving open for other possible files.
Created attachment 644063 [details] [diff] [review] fix files in browser/base I did a quick pass and tried to fix the files in browser/base. I haven't looked over this carefully, it may have bugs.
I'll continue with this.
Question, the %if 0 or #if 0 directives are required for some reason or can be removed?
It depends on the specific use. But I don't think you should worry about those to start - let's just get the ones that the preprocessor warns about to begin with.
Created attachment 651450 [details] [diff] [review] Patch v1 browser/base browser/base fixes.
Created attachment 651451 [details] [diff] [review] Patch v1 browser/components browser/components fixes.
Created attachment 651452 [details] [diff] [review] Patch v1 browser/locales browser/locales fixes.
Created attachment 651453 [details] [diff] [review] Patch v1 browser/themes browser/themes fixes.
I'll continue with toolkit files
Toolkit files are fine. Any other I should check?
We want to fix all the warnings that show up during a mozilla-central firefox build, but I imagine there may be a long tail. Don't need to tackle that in this bug, might be good to file a followup.
Created attachment 651795 [details] [diff] [review] rolled up browser/ patch Thanks for fixing this, Andres!
Thank you, do we need a try run for this?