325924 - compare-locales gets confused on #ifdefs

Status: RESOLVED WONTFIX

(Toolkit Graveyard :: Build Config, defect)

Description

[Marek Stępień [:marcoos, inactive]]

Fix for bug 320504 introduced #ifdefs into l10n files:

#ifdef OFFICIAL_BRANDING
#define BRAND_PRODUCT_NAME Mozilla Firefox
#else
#define BRAND_PRODUCT_NAME Deer Park Alpha 2
#endif

This confuses compare-locales (it reports that BRAND_PRODUCT_NAME and some others are missing in the localization, while actually they are there twice) and makes l10n tinderbox orange at best.

Example of a build log with compare-locales whining about uninstaller.inc's #ifdef-ed strings:

http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n-pl/1139085120.29861.gz&fulltext=1

Comment 1

[Marek Stępień [:marcoos, inactive]]

Sorry, the URL to the tinderbox was wrong. The one I meant was:
http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n-pl/1139089800.20058.gz&fulltext=1

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

It's because compare-locales always reports a missing string if the string appears in file more than once. Even if it appears in both files equally. Fixing it would fix this bug.

Comment 3

[Axel Hecht [:Pike]]

I don't see us supporting #ifdefs reliably in the toolchain.

Let alone QA it. If someone has a working solution for it, reopen.

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

(In reply to comment #3)
> I don't see us supporting #ifdefs reliably in the toolchain.
> 
> Let alone QA it. If someone has a working solution for it, reopen.
> 

Pike, in case of this file, it will make tinderbox ALWAYS orange, do we want this?

Comment 5

[Marek Stępień [:marcoos, inactive]]

Gandalf:
compare-locales now ignores uninstaller.inc, see bug 320504 comment 47, so it's not making tboxes orange (trunk tboxes are now burining only due to reporter l10n SNAFU).