Closed Bug 325948 Opened 19 years ago Closed 19 years ago

crash quiting application while a download is in progress

Categories

(Toolkit :: Downloads API, defect)

Product:
Toolkit
Component:
Downloads API
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8.1

People

(Reporter: darin.moz, Assigned: darin.moz)

References

Details

(Keywords: crash, fixed1.8.1)

Attachments

(1 file, 2 obsolete files)

v1 patch
1.94 KB, patch
mconnor
: review+
benjamin
: approval-branch-1.8.1+
Details | Diff | Splinter Review
crash quiting application while a download is in progress nsDownloadManager::CancelDownload calls DownloadEnded, which if gStoppingDownloads is true, clears the internal nsDownload object from mCurrDownloads. After calling DownloadEnded, CancelDownload calls methods on the internal nsDownload object. That results in a crash. I observed this crash using a CVS trunk build of FF (pulled on Feb 2nd) on windows. It happens if you have a download in progress, close the app, and click the "cancel" button in the dialog that prompts you about what to do with downloads that are in progress.
Attached patch v1 patch (obsolete) — — Splinter Review
Attachment #210732 - Flags: review?
Attached patch v1 patch (obsolete) — — Splinter Review
Attachment #210733 - Flags: review?
Attached patch v1 patch — — Splinter Review
Attachment #210734 - Flags: review?(mconnor)
Attachment #210732 - Attachment is obsolete: true
Attachment #210732 - Flags: review?
Attachment #210733 - Attachment is obsolete: true
Attachment #210733 - Flags: review?
(There really should be a toolkit: downloads bugzilla component.)
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox 2
Sounds like this one: Bug 313999.
*** Bug 313999 has been marked as a duplicate of this bug. ***
Attachment #210734 - Flags: review?(mconnor) → review+
Attachment #210734 - Flags: branch-1.8.1?(benjamin)
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Attachment #210734 - Flags: branch-1.8.1?(benjamin) → branch-1.8.1+
fixed1.8.1
Keywords: fixed1.8.1
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: