32595 - BAD: browser crashed on links.

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[Loren Cannon]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; N; Win98; en-US; m14)
BuildID:    2000032011

the browser crashes if you click the on-site links.  GPF

Reproducible: Always
Steps to Reproduce:
1.open www.theregister.co.uk	
2.click on an on-site link
3.XXX


Actual Results:  GPF

Expected Results:  hmmm...

Comment 1

[Christine Begle]

just before the crash i get an assertion:

###!!! ASSERTION: You can't dereference a NULL nsCOMPtr with operator->().: 
'mRawPtr != 0', file ..\
..\..\dist\include\nsCOMPtr.h, line 609

assigning to norris since he wrote the crashy part.  sorry norris!

stack trace:
GenerateTree(const char * 0x041abe50, nsIWebShell * 0x037c89d8, nsIWebShell * 
0x037d0148, nsHistoryEntry * 0x041ac040, nsISessionHistory * 0x03845720, const 
char * 0x0012f62c) line 461 + 54 bytes
GenerateTree(const char * 0x041abe50, nsIWebShell * 0x037c89d8, nsIWebShell * 
0x037951c8, nsHistoryEntry * 0x00000000, nsISessionHistory * 0x03845720, const 
char * 0x0012f62c) line 478 + 37 bytes
nsSessionHistory::Add(nsSessionHistory * const 0x03845720, const char * 
0x041abe50, const char * 0x0012f62c, nsIWebShell * 0x037c89d8) line 960 + 27 
bytes
nsWebShell::LoadURL(nsWebShell * const 0x037c89d8, const unsigned short * 
0x041ae3b0, const char * 0x00391050, nsIInputStream * 0x00000000, int 1, 
unsigned int 0, const unsigned int 0, nsISupports * 0x00000000, const unsigned 
short * 0x0012fc24, const char * 0x0012fbc8) line 1737 + 95 bytes
nsWebShell::HandleLinkClickEvent(nsIContent * 0x03c7056c, nsLinkVerb 
eLinkVerb_Replace, const unsigned short * 0x041ae3b0, const unsigned short * 
0x10084580 gCommonEmptyBuffer, nsIInputStream * 0x00000000) line 2174 + 89 bytes
OnLinkClickEvent::HandleEvent() line 2065
HandlePLEvent(OnLinkClickEvent * 0x041ae2d0) line 2078
PL_HandleEvent(PLEvent * 0x041ae2d0) line 563 + 10 bytes
PL_ProcessPendingEvents(PLEventQueue * 0x0101acd0) line 508 + 9 bytes
_md_EventReceiverProc(HWND__ * 0x044d05e0, unsigned int 49335, unsigned int 0, 
long 16886992) line 1018 + 9 bytes
USER32! 77e71268()
0101acd0()

Comment 2

[Loren Cannon]

Workaround : Open in new Window

Comment 3

[Norris Boyd]

Fixed:
Checking in xpfe/appshell/src/nsSessionHistory.cpp;
/m/pub/mozilla/xpfe/appshell/src/nsSessionHistory.cpp,v  <--  nsSessionHistory.c
pp
new revision: 1.42; previous revision: 1.41
done

Comment 4

[leger]

Adding crash keyword

Comment 5

[Christian Mattar]

Verified on Win98 2000042608.