Closed Bug 325985 Opened 20 years ago Closed 20 years ago

no need for a localized version number

Categories

(Calendar :: Sunbird Only, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wolfiR, Assigned: wolfiR)

References

Details

Attachments

(1 file, 3 obsolete files)

IMHO there is no need to have a localized version number for Sunbird.
in addition we have a hardcoded lang.version in brand.dtd :-(
Attached patch patch #1 (obsolete) — Splinter Review
Attachment #210764 - Flags: first-review?
Attachment #210764 - Flags: first-review? → first-review?(mvl)
Attached patch patch #2 (obsolete) — Splinter Review
all this preprocessing stuff for brand.dtd in not needed. So together with this patch brand.dtd.in has to be renamed to brand.dtd!
Assignee: nobody → mozilla
Attachment #210764 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #210768 - Flags: first-review?
Attachment #210764 - Flags: first-review?(mvl)
Attachment #210768 - Flags: first-review? → first-review?(mvl)
Attached patch patch #3 (obsolete) — Splinter Review
sorry, there was one change not related to this bug in patch #2
Attachment #210768 - Attachment is obsolete: true
Attachment #210768 - Flags: first-review?(mvl)
Attachment #210770 - Flags: second-review?(dmose)
Attachment #210770 - Flags: first-review?(mvl)
Comment on attachment 210770 [details] [diff] [review] patch #3 We want to move the branding stuff to the new location at the same time. So I have to create a new more complete patch.
Attachment #210770 - Flags: second-review?(dmose)
Attachment #210770 - Flags: first-review?(mvl)
Depends on: 326003
Attached patch patch #4Splinter Review
we need the branding stuff under calendar/locales prior to this one
Attachment #210799 - Flags: first-review?(dmose)
Attachment #210770 - Attachment is obsolete: true
Attachment #210799 - Flags: second-review?(mvl)
Comment on attachment 210799 [details] [diff] [review] patch #4 clearing flags until we sorted out how to handle jar creation in the end
Attachment #210799 - Flags: second-review?(mvl)
Attachment #210799 - Flags: first-review?(dmose)
This has been fixed with the move of the branding stuff to calendar/locales
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: