326060 - Templates should not check for flag.setter; it is always known

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Olav Vitters]

From bug 219555 comment 24:
> >+                        [% IF flag.setter %]
> >+                          [% flag.setter.nick FILTER html %]:
> >+                        [% END %]
> 
> Nit: a flag *always* has a setter, so there is no need to check whether one is
> defined; you already know there is one. This test is useless. This concerns
> both bug and attachment flags.

This code was taken from existing template files. It originates in bug 98801 attachment 100965 [details] [diff] [review] (patch v32). The review (bug 98801 comment 109) didn't request that change though. Bugzilla/Flag.pm assumes the setter is known (creates a user instance from it).

Comment 1

[Olav Vitters]

Attachment: Patch v1: Bugzilla CVS 2006-02-06

Comment 2

[Frédéric Buclin]

Comment on attachment 210850 [details] [diff] [review]
Patch v1: Bugzilla CVS 2006-02-06

r=LpSolit by inspection.

If a setter is missing, this means that the user account has been deleted despite the warnings displayed by editusers.cgi. No error is added to the error log, though.

Comment 3

[Vlad Dascalu]

Checking in template/en/default/attachment/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/list.html.tmpl,v  <--  list.html.tmpl
new revision: 1.27; previous revision: 1.26
done
Checking in template/en/default/attachment/show-multiple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/show-multiple.html.tmpl,v  <--  show-multiple.html.tmpl
new revision: 1.17; previous revision: 1.16
done
Checking in template/en/default/bug/show.xml.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/show.xml.tmpl,v  <--  show.xml.tmpl
new revision: 1.12; previous revision: 1.11
done