326123 - Add 1px horizontal padding to the anonymous div in text inputs and textareas

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Uri Bernstein]

This is a followup on the discussion in bug 233348. See bug 233348 comment #28 point #2.

Adding a 1px horizontal padding on both sides of the anonymous div inside textareas and inputs will result in pixel-compatability with IE6/Win. It will also make textareas and inputs look better on other platforms. Notice that the outer dimentions of the controls themselves should *not* be adjusted to "compensate" for the 1px padding, if compatability with IE is required. See attachment 209292 [details] for screenshots comparing the current rendering on IE6 and Firefox.

Comment 1

[Uri Bernstein]

Attachment: patch

Comment 2

[Uri Bernstein]

s/compatability/parity/g in comment #0.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 210905 [details] [diff] [review]
patch

Add some nice comments, please?

Comment 4

[Uri Bernstein]

(In reply to comment #3)
> Add some nice comments, please?

Like this?

/* The 1px horizontal padding is required for parity with Win/IE */

Comment 5

[Boris Zbarsky [:bzbarsky]]

For example.  ;)

Comment 6

[Uri Bernstein]

Checking in layout/style/forms.css;
/cvsroot/mozilla/layout/style/forms.css,v  <--  forms.css
new revision: 3.114; previous revision: 3.113

Comment 7

[[e-mail]]

I just verified that backing out this patch fixes the issue I mentioned in bug 328040 comment 3.