Closed Bug 326123 Opened 14 years ago Closed 14 years ago

Add 1px horizontal padding to the anonymous div in text inputs and textareas

Categories

(Core :: Layout: Form Controls, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: uriber, Assigned: uriber)

References

(Depends on 1 open bug, )

Details

Attachments

(1 file)

This is a followup on the discussion in bug 233348. See bug 233348 comment #28 point #2.

Adding a 1px horizontal padding on both sides of the anonymous div inside textareas and inputs will result in pixel-compatability with IE6/Win. It will also make textareas and inputs look better on other platforms. Notice that the outer dimentions of the controls themselves should *not* be adjusted to "compensate" for the 1px padding, if compatability with IE is required. See attachment 209292 [details] for screenshots comparing the current rendering on IE6 and Firefox.
Attached patch patchSplinter Review
Attachment #210905 - Flags: review?
Attachment #210905 - Flags: review? → review?(dbaron)
s/compatability/parity/g in comment #0.
Attachment #210905 - Flags: review?(dbaron) → review+
Attachment #210905 - Flags: superreview?(bzbarsky)
Comment on attachment 210905 [details] [diff] [review]
patch

Add some nice comments, please?
Attachment #210905 - Flags: superreview?(bzbarsky) → superreview+
(In reply to comment #3)
> Add some nice comments, please?

Like this?

/* The 1px horizontal padding is required for parity with Win/IE */
For example.  ;)
Checking in layout/style/forms.css;
/cvsroot/mozilla/layout/style/forms.css,v  <--  forms.css
new revision: 3.114; previous revision: 3.113
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Depends on: 326926
I just verified that backing out this patch fixes the issue I mentioned in bug 328040 comment 3.
Depends on: 335283
You need to log in before you can comment on or make changes to this bug.