326150 - fix ja-JP, ja-JPM and ko-KR Yahoo! search plugin on 1.0.x branch

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Mike Shaver (:shaver emeritus)]

We took some changes in 1.0.1 that resulted in our search codes not being attached to Yahoo! searches from 1.0.1 through 1.0.7.  We'd like to resolve that.

In order to preserve the space-containing name for display, we need to bake the search code right into the plugin.  We should just take the ja-JP yahoo-jp.src and make it the yahoo.src for 1.0.x ja-JP localizations, IMO.

Comment 1

[Mike Shaver (:shaver emeritus)]

Also for ja-JPM and ko-KR.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: Copy the plugins from the 1.8.0 branch

I copied the plugins from the 1.8.0 branch to 1.0.x, which from what I can tell is all there is to this bug.

Comment 3

[Mike Shaver (:shaver emeritus)]

Comment on attachment 211153 [details] [diff] [review]
Copy the plugins from the 1.8.0 branch

sr=shaver, let's get mconnor on this as a sanity check as well.

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 211153 [details] [diff] [review]
Copy the plugins from the 1.8.0 branch

a=dveditz

Comment 5

[Chris Cooper [:coop] (he/him)]

Checking in browser/locales/ja-JP/searchplugins/yahoo.src;
/l10n/mozilla/browser/locales/ja-JP/searchplugins/Attic/yahoo.src,v  <--  yahoo.src
new revision: 1.1.2.6; previous revision: 1.1.2.5
done
Checking in browser/locales/ja-JPM/searchplugins/yahoo.src;
/l10n/mozilla/browser/locales/ja-JPM/searchplugins/Attic/yahoo.src,v  <--  yahoo.src
new revision: 1.1.2.6; previous revision: 1.1.2.5
done
Checking in browser/locales/ko-KR/searchplugins/yahoo.src;
/l10n/mozilla/browser/locales/ko-KR/searchplugins/Attic/yahoo.src,v  <--  yahoo.src
new revision: 1.1.2.3; previous revision: 1.1.2.2
done

Comment 6

[Tim Riley [:timr]]

We can add the fixed-aviary1.0.8 keyword now, right?

Comment 7

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #6)
> We can add the fixed-aviary1.0.8 keyword now, right?

Yes.

Comment 8

[Rafael Ebron (:rebron)]

There were two other plug-ins for Yahoo!Japan in 1.5, one for shopping and another for auctions.  I don't see that in the patch unless I'm missing something.
http://lxr.mozilla.org/l10n-mozilla1.8.0/source/ja/browser/searchplugins/yahoo-jp-auctions.src
http://lxr.mozilla.org/l10n-mozilla1.8.0/source/ja/browser/searchplugins/yahoo-jp-shopping.src

Comment 9

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #8)
> There were two other plug-ins for Yahoo!Japan in 1.5, one for shopping and
> another for auctions.  I don't see that in the patch unless I'm missing
> something.
> http://lxr.mozilla.org/l10n-mozilla1.8.0/source/ja/browser/searchplugins/yahoo-jp-auctions.src
> http://lxr.mozilla.org/l10n-mozilla1.8.0/source/ja/browser/searchplugins/yahoo-jp-shopping.src
> 

I added these to the patch attached to bug 326151.