326203 - Add build info for VC 8

Status: RESOLVED DUPLICATE of bug 249782

(Core :: JavaScript Engine, defect)

Description

[Michael Daumling]

For VC 8, the following flags need to be set/changed:

Compiler:
-O2 leads to a crash which goes away with -O1 (at least in my configuration)
-Op is not longer recognized
-D_CRT_SECURE_NO_DEPRECATE suppresses silly deprecated warnings

Linker:
Add /MANIFEST
Add the following post-link command to embed a manifest for the CRT DLLs into the final DLLs and executables:

	mt.exe -nologo -outputresource:$@ -manifest $@.manifest

Comment 1

[Michael Daumling]

Let me know if the flag settings are OK with you, and I'll patch the config/WINNT* files

Comment 2

[Brendan Eich [:brendan]]

(In reply to comment #0)
> For VC 8, the following flags need to be set/changed:
> 
> Compiler:
> -O2 leads to a crash which goes away with -O1 (at least in my configuration)

This sounds like a bug, either in SpiderMonkey (but not encounted yet on any other compiler/OS combo) or in VC8.  Where is the crash?  What local state?

/be

Comment 3

[Michael Daumling]

It appears to be a VC8 bug. I don't exactly recall the stack trace - it happens at the beginning of the first parse operation in the compiler; the problem was that the generated code pushed the cx parameter for a function call, and the opcode generated was an offset to ESP which was just plain wrong, causing NULL to be pushed instead of the actual value of cx.

The VC8 linker also has a bad attitude when linking js as a static lib: All of the property stubs are folded into one function body, so code that compares a function pointer to a certain stub (e.g. clasp->getProperty == js_GetLocalVariable) is a false positive if the function actually is JS_PropertyStub! So I needed to add /opt:noref to my linker command so the linker actually kept the stubs at separate addesses. When linking as a DLL, this does not seem to happen.

Comment 4

[Michael Daumling]

249782 already deals with VC8 issues.

*** This bug has been marked as a duplicate of 249782 ***