326238 - xulrunner fails if <installdir>/extensions is not available and cannot be written

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

If the installation-directory is not writable by xulrunner it fails and exits w/o giving an obvious error message.

1. I think the build should create the extensions directory already
2. xulrunner shouldn't fail silently trying to create that directory

Comment 1

[Benjamin Smedberg]

-> EM

Comment 2

[Robert Strong (they/them - no direct email)]

This was caused by bug 323956. Looks like it was using mozilla\xulrunner\app\profile\extensions to create the extensions directory in the app directory. I will most likely just change DirectoryInstallLocation so it won't throw when it is unable to create a missing directory so it will handle this properly whether or not the app provides an extensions directory.

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: patch

This needs additional testing but so far so good.

Comment 4

[Robert Strong (they/them - no direct email)]

Tested successfully with Firefox and with a couple of XULRunner apps.

Comment 5

[Robert Strong (they/them - no direct email)]

Checked in on trunk and MOZILLA_1_8_BRANCH

Comment 6

[Benjamin Smedberg]

Comment on attachment 211075 [details] [diff] [review]
patch

Want this for xulrunner; according to robstrong and my own review this is very safe since it just adds a try/catch block.

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 211075 [details] [diff] [review]
patch

approved for 1.8.0 branch, a=dveditz for drivers

Comment 8

[Robert Strong (they/them - no direct email)]

Attachment: patch updated for 1.8.0

Comment 9

[Robert Strong (they/them - no direct email)]

Checked in to MOZILLA_1_8_0 for 1.8.0.2

Checking in mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in;
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v  <--  nsExtensionManager.js.in
new revision: 1.144.2.16.2.3; previous revision: 1.144.2.16.2.2

Comment 10

[Dave Liebreich [:davel]]

ready for testing in firefox 1.5.0.2.  I think tha the following testcase will cover this bug - please comment if more is needed:

After installing but before running firefox, set the install directory read-only and remove the extensions directory if it exists.  Then run Firefox