Closed Bug 326270 Opened 14 years ago Closed 14 years ago

In some cases, calWeekTitleService might get wrong results

Categories

(Calendar :: Internal Components, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mvl, Assigned: martinschroeder)

Details

Attachments

(1 file)

In somecases, (at the end of the year of certain leap-years) the result of calWeekTitleService might be off.
see bug 319790 comment 25
Status: NEW → ASSIGNED
Attached patch Patch v1Splinter Review
* fixed typo of variable startWeekday (now the start of the week is read from the preferences)
* fixed handling of end/start of year to be more accurate
* fixed comments for the changed code
Assignee: base → mschroeder
Attachment #217730 - Flags: first-review?(mvl)
Comment on attachment 217730 [details] [diff] [review]
Patch v1

looks good, and passed my (few) tests.
r=mvl
Attachment #217730 - Flags: first-review?(mvl) → first-review+
Whiteboard: [needs landing]
patch checked in on trunk and MOZILLA_1_8_BRANCH
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
You need to log in before you can comment on or make changes to this bug.