326281 - Missing SAVE_SP_AND_PC calls before js_CheckRedeclaration calls

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Brendan Eich [:brendan]]

in jsinterp.c.  Patch spun out from bug 325960 for 1.8.1 and js1.6rc1 nomination.

/be

Comment 1

[Brendan Eich [:brendan]]

Attachment: fix

r=mrbkap already.

/be

Comment 2

[Bob Clary [:bc] (inactive)]

Can we get this checked in soon?

Comment 3

[Brendan Eich [:brendan]]

Need help, jury duty.

/be

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

This landed as part of the fix for bug 325960, I think this bug was just for the nominations and such. The patch is malformed, however, so I'll attach a new one.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Patch for the 1.8 branch

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

This is fixed on trunk and branch.

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Patch for the 1.8.0 branch

This is late notice, but it'd be nice to get this crash fix on the 1.8.0 branch. This could result in the use of deleted memory, which is a Bad Thing (TM).

This fix has been on both the 1.8 branch and the trunk since the beginning of April.

Comment 8

[Tim Riley [:timr]]

Comment on attachment 221030 [details] [diff] [review]
Patch for the 1.8.0 branch

The release team discussed this today.  It is a valuable and safe fix.  We are re-spinning for another critical bug.  So this can be added also.  Land ASAP!  a=timr for drivers.

Comment 9

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into the 1.8.0 branch.

Comment 10

[Bob Clary [:bc] (inactive)]

verified on 1.8.0 and 1.8 by code inspection.