Convert bookmark add/remove functionality to use controller.js

RESOLVED FIXED in Firefox 2 alpha2

Status

()

Firefox
Bookmarks & History
P1
normal
RESOLVED FIXED
13 years ago
9 years ago

People

(Reporter: Joe Hughes, Assigned: Joe Hughes)

Tracking

({fixed1.8.1})

Trunk
Firefox 2 alpha2
fixed1.8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: swag 1 (actual was ~0.5))

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

13 years ago
Currently, the bookmark add/remove functionality goes directly to the Bookmarks Service.  In order to make these actions undoable, they should go through the controller.js interface in Places.
Priority: -- → P2
Priority: P2 → P1
(Assignee)

Comment 1

12 years ago
Created attachment 216157 [details] [diff] [review]
Moves transactions to a separate file and converts bookmark properties dialog actions (except change URI) to use transaction manager
Approach looks OK So far...
(Assignee)

Updated

12 years ago
Whiteboard: swag 1
(Assignee)

Comment 3

12 years ago
Created attachment 216790 [details] [diff] [review]
Updated version of previous patch (some updates; also dispenses with transactions.js)
Attachment #216157 - Attachment is obsolete: true
Attachment #216790 - Flags: superreview?(bugs)
Attachment #216790 - Flags: review?(annie.sullivan)

Updated

12 years ago
Attachment #216790 - Flags: review?(annie.sullivan) → review+
Comment on attachment 216790 [details] [diff] [review]
Updated version of previous patch (some updates; also dispenses with transactions.js)

sr=ben@mozilla.org
Attachment #216790 - Flags: superreview?(bugs) → superreview+
(Assignee)

Comment 5

12 years ago
Landed on branch & trunk.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: swag 1 → swag 1 (actual was ~0.5)

Updated

11 years ago
Flags: blocking-firefox3?

Comment 6

11 years ago
this is a test

Updated

11 years ago
Flags: blocking-firefox3?
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.