326564 - Better support for unknown roles

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

When there's a role we don't know, we should:
- expose the label and description
- don't say it's focusable unless it is
- expose the role in the role string

Comment 1

[Aaron Leventhal]

Attachment: Test case

Comment 2

[Aaron Leventhal]

Attachment: Don't use mRoleMapEntry to determine if we have a DHTML role -- check for presence of xhtml2:role

Comment 3

[parente]

Comment on attachment 211288 [details] [diff] [review]
Don't use mRoleMapEntry to determine if we have a DHTML role -- check for presence of xhtml2:role

Addition of } in nsAccessibleWrap has weird indentation in the patch. Otherwise OK.

Comment 4

[[e-mail]]

Comment on attachment 211288 [details] [diff] [review]
Don't use mRoleMapEntry to determine if we have a DHTML role -- check for presence of xhtml2:role

>-    if (mRoleMapEntry) {
I assume there are still other users of this variable.

>+		}
Yes, you've got tabs here, when you need to have spaces.

Comment 5

[Aaron Leventhal]

Checking in src/base/nsAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsAccessible.cpp,v  <--  nsAccessible.cpp
new revision: 1.173; previous revision: 1.172
done
Checking in src/msaa/nsAccessibleWrap.cpp;
/cvsroot/mozilla/accessible/src/msaa/nsAccessibleWrap.cpp,v  <--  nsAccessibleWrap.cpp
new revision: 1.36; previous revision: 1.35
done