326627 - Forward inline fails for S/MIME signed and encrypted emails

Status: RESOLVED WORKSFORME

(Thunderbird :: Message Compose Window, defect)

Description

[rocketraman]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060124 Firefox/1.5.0.1
Build Identifier: version 1.5 (20051201)

When an S/MIME signed and encrypted email is received, and one attempts to forward it inline, Thunderbird fails to forward it inline, but instead adds it as an attachment. 

This is similar to bug #2903, and as per the discussion in that bug, this behavior is correct because the incoming message type has a non-text or mixed content type (https://bugzilla.mozilla.org/show_bug.cgi?id=2903#c27). The content type of the encrypted, signed message may be:

Content-Type: application/x-pkcs7-mime;
	smime-type=enveloped-data;
	name="smime.p7m"

However, in actuality, encrypted data is special, because the enveloped data may actually be textual or mixed, and therefore I believe that for encrypted emails the Content-Type of the enveloped data should be checked when deciding whether to forward inline as the user as requested, or as an attachment.

Note that inline forwarding a signed-only email (as opposed to signed and encrypted) DOES simply inline the forwarded email. In addition, oddly enough, forwarding an encrypted-only email also inlines the forwarded email (so in this case the content type of the enveloped data IS being checked). Therefore, I can see no reason why the same behavior should not be maintained for emails that are both signed and encrypted.

Reproducible: Always

Steps to Reproduce:
1. Received a signed and encrypted email
2. Choose Forward Inline
3.

Actual Results:  
Message is forwarded as an attachment.

Expected Results:  
Message should be forwarded inline, which would be consistent with the behavior when forwarding encrypted-only or signed-only emails.

Comment 1

[rocketraman]

This is also similar to bug #217979, but that bug is in reference to encrypted messages, not signed and encrypted messages.  Forward inline on encrypted messages works fine for me on 1.5 (20051201).  However, these bugs are close enough that they may or may not be considered duplicates...

Comment 2

[rocketraman]

This appears to be fixed in version 2.0.0.9 on Fedora Core 8.