326694 - Core::GetRegistryTree should not use NS_ENSURE_TRUE for registry->GetKey calls

Status: RESOLVED DUPLICATE of bug 285465

(Core Graveyard :: Profile: Roaming, enhancement)

Description

[timeless]

Please don't ns_ensure_true something you expect to fail.
The caller (Core::ReadRoamingPrefs) does:
  if (NS_FAILED(rv)) // expected, if roaming not set up for this profile
    mIsRoaming = PR_FALSE;
and then properly returns without triggering a warning. the callee should do the same.

00 ntdll!DbgBreakPoint (FPO: [0,0,0])
01 xpcom_core!nsDebugImpl::Break(char * aFile = 0x00d9a724 "r:/mozilla/extensions/sroaming/src/Core.cpp", int aLine = 304)+0x7e (FPO: [Non-Fpo]) (CONV: stdcall) [r:\mozilla\xpcom\base\nsdebugimpl.cpp @ 353]
02 xpcom_core!nsDebugImpl::Warning(char * aMessage = 0x00d9a750 "NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed", char * aFile = 0x00d9a724 "r:/mozilla/extensions/sroaming/src/Core.cpp", int aLine = 304)+0x12a (FPO: [Non-Fpo]) (CONV: stdcall) [r:\mozilla\xpcom\base\nsdebugimpl.cpp @ 418]
03 xpcom_core!NSGlue_Warning(char * aStr = 0x00d9a750 "NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed", char * aFile = 0x00d9a724 "r:/mozilla/extensions/sroaming/src/Core.cpp", int aLine = 304)+0x51 (FPO: [Non-Fpo]) (CONV: fastcall) [r:\mozilla\dbg-i686-pc-cygwin\xpcom\build\nsdebug.cpp @ 102]
04 sroaming!Core::GetRegistryTree(unsigned int * result = 0x0012c508)+0x2ae (FPO: [Non-Fpo]) (CONV: thiscall) [r:\mozilla\extensions\sroaming\src\core.cpp @ 304]
05 sroaming!Core::ReadRoamingPrefs(void)+0x78 (FPO: [Non-Fpo]) (CONV: thiscall) [r:\mozilla\extensions\sroaming\src\core.cpp @ 322]
06 sroaming!Core::BeginSession(void)+0xe (FPO: [Non-Fpo]) (CONV: stdcall) [r:\mozilla\extensions\sroaming\src\core.cpp @ 83]
07 profile!nsProfile::SetCurrentProfile(unsigned short * aCurrentProfile = 0x02af3690 "default")+0x85b (FPO: [Non-Fpo]) (CONV: stdcall) [r:\mozilla\profile\src\nsprofile.cpp @ 1269]
08 xpcom_core!XPTC_InvokeByIndex(class nsISupports * that = 0x00d421b8, unsigned int methodIndex = 7, unsigned int paramCount = 1, struct nsXPTCVariant * params = 0x0012c7c8)+0x27 (CONV: cdecl) [r:\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcinvoke.cpp @ 102]
09 xpc3250!XPCWrappedNative::CallMethod(class XPCCallContext * ccx = 0x0012c990, XPCWrappedNative::CallMode mode = CALL_SETTER (2))+0xdd5 (FPO: [Non-Fpo]) (CONV: cdecl) [r:\mozilla\js\src\xpconnect\src\xpcwrappednative.cpp @ 2155]
0a xpc3250!XPCWrappedNative::SetAttribute(class XPCCallContext * ccx = 0x0012c990)+0xe (FPO: [Non-Fpo]) (CONV: cdecl) [r:\mozilla\js\src\xpconnect\src\xpcprivate.h @ 1975]
0b xpc3250!XPC_WN_GetterSetter(struct JSContext * cx = 0x00d4c570, struct JSObject * obj = 0x022593f0, unsigned int argc = 1, long * argv = 0x02ad8658, long * vp = 0x0012cab8)+0x1db (FPO: [Non-Fpo]) (CONV: cdecl) [r:\mozilla\js\src\xpconnect\src\xpcwrappednativejsops.cpp @ 1495]
0c js3250!js_Invoke(struct JSContext * cx = 0x00d4c570, unsigned int argc = 1, unsigned int flags = 2)+0xd5d (FPO: [Non-Fpo]) (CONV: cdecl) [r:\mozilla\js\src\jsinterp.c @ 1234]
0d js3250!js_InternalInvoke(struct JSContext * cx = 0x00d4c570, struct JSObject * obj = 0x022593f0, long fval = 44800008, unsigned int flags = 0, unsigned int argc = 1, long * argv = 0x0012d61c, long * rval = 0x0012d61c)+0x115 (FPO: [Non-Fpo]) (CONV: cdecl) [r:\mozilla\js\src\jsinterp.c @ 1335]
0e js3250!js_InternalGetOrSet(struct JSContext * cx = 0x00d4c570, struct JSObject * obj = 0x022593f0, long id = 37181496, long fval = 44800008, JSAccessMode mode = JSACC_WRITE (8), unsigned int argc = 1, long * argv = 0x0012d61c, long * rval = 0x0012d61c)+0x215 (CONV: cdecl) [r:\mozilla\js\src\jsinterp.c @ 1394]
0f js3250!js_SetProperty(struct JSContext * cx = 0x00d4c570, struct JSObject * obj = 0x022593f0, long id = 37181496, long * vp = 0x0012d61c)+0x9b8 (FPO: [Non-Fpo]) (CONV: cdecl) [r:\mozilla\js\src\jsobj.c @ 3171]
10 js3250!js_Interpret(struct JSContext * cx = 0x00d4c570, unsigned char * pc = 0x02390ab1 "6", long * result = 0x0012d76c)+0xc515 (FPO: [Non-Fpo]) (CONV: cdecl) [r:\mozilla\js\src\jsinterp.c @ 3626]
11 js3250!js_Invoke(struct JSContext * cx = 0x00d4c570, unsigned int argc = 1, unsigned int flags = 2)+0xdcd (FPO: [Non-Fpo]) (CONV: cdecl) [r:\mozilla\js\src\jsinterp.c @ 1258]
12 js3250!js_InternalInvoke(struct JSContext * cx = 0x00d4c570, struct JSObject * obj = 0x0225a668, long fval = 44799608, unsigned int flags = 0, unsigned int argc = 1, long * argv = 0x0012da78, long * rval = 0x0012da7c)+0x115 (FPO: [Non-Fpo]) (CONV: cdecl) [r:\mozilla\js\src\jsinterp.c @ 1335]
13 js3250!JS_CallFunctionValue(struct JSContext * cx = 0x00d4c570, struct JSObject * obj = 0x0225a668, long fval = 44799608, unsigned int argc = 1, long * argv = 0x0012da78, long * rval = 0x0012da7c)+0x48 (FPO: [Non-Fpo]) (CONV: cdecl) [r:\mozilla\js\src\jsapi.c @ 4213]
14 gklayout!nsJSContext::CallEventHandler(struct JSObject * aTarget = 0x0225a668, struct JSObject * aHandler = 0x02ab9678, unsigned int argc = 1, long * argv = 0x0012da78, long * rval = 0x0012da7c)+0x128 (FPO: [Non-Fpo]) (CONV: thiscall) [r:\mozilla\dom\src\base\nsjsenvironment.cpp @ 1439]
15 gklayout!nsJSEventListener::HandleEvent(class nsIDOMEvent * aEvent = 0x02af6940)+0x58b (FPO: [Non-Fpo]) (CONV: stdcall) [r:\mozilla\dom\src\events\nsjseventlistener.cpp @ 223]
16 gklayout!nsXBLPrototypeHandler::ExecuteHandler(class nsIDOMEventReceiver * aReceiver = 0x02abcc10, class nsIDOMEvent * aEvent = 0x02af6940)+0x183b (FPO: [Non-Fpo]) (CONV: thiscall) [r:\mozilla\content\xbl\src\nsxblprototypehandler.cpp @ 507]
17 gklayout!nsXBLKeyEventHandler::HandleEvent(class nsIDOMEvent * aEvent = 0x02af6940)+0x172 (FPO: [Non-Fpo]) (CONV: stdcall) [r:\mozilla\content\xbl\src\nsxbleventhandler.cpp @ 153]
18 gklayout!nsEventListenerManager::HandleEventSubType(struct nsListenerStruct * aListenerStruct = 0x023bddf0, class nsIDOMEventListener * aListener = 0x023aea68, class nsIDOMEvent * aDOMEvent = 0x02af6940, class nsIDOMEventTarget * aCurrentTarget = 0x02abcc10, unsigned int aSubType = 4, unsigned int aPhaseFlags = 0x202)+0x23a (FPO: [Non-Fpo]) (CONV: thiscall) [r:\mozilla\content\events\src\nseventlistenermanager.cpp @ 1670]
19 gklayout!nsEventListenerManager::HandleEvent(class nsPresContext * aPresContext = 0x02255ae0, class nsEvent * aEvent = 0x0012eee8, class nsIDOMEvent ** aDOMEvent = 0x0012ec00, class nsIDOMEventTarget * aCurrentTarget = 0x02abcc10, unsigned int aFlags = 0x202, nsEventStatus * aEventStatus = 0x0012ed10)+0x398 (FPO: [Non-Fpo]) (CONV: stdcall) [r:\mozilla\content\events\src\nseventlistenermanager.cpp @ 1777]
1a gklayout!nsXULElement::HandleDOMEvent(class nsPresContext * aPresContext = 0x02255ae0, class nsEvent * aEvent = 0x0012eee8, class nsIDOMEvent ** aDOMEvent = 0x0012ec00, unsigned int aFlags = 0x202, nsEventStatus * aEventStatus = 0x0012ed10)+0xc3e (FPO: [Non-Fpo]) (CONV: thiscall) [r:\mozilla\content\xul\content\src\nsxulelement.cpp @ 1885]
1b gklayout!nsXULElement::HandleDOMEvent(class nsPresContext * aPresContext = 0x02255ae0, class nsEvent * aEvent = 0x0012eee8, class nsIDOMEvent ** aDOMEvent = 0x0012ec00, unsigned int aFlags = 0x202, nsEventStatus * aEventStatus = 0x0012ed10)+0xd5d (FPO: [Non-Fpo]) (CONV: thiscall) [r:\mozilla\content\xul\content\src\nsxulelement.cpp @ 1904]
1c gklayout!nsXULElement::HandleDOMEvent(class nsPresContext * aPresContext = 0x02255ae0, class nsEvent * aEvent = 0x0012eee8, class nsIDOMEvent ** aDOMEvent = 0x0012ec00, unsigned int aFlags = 0x202, nsEventStatus * aEventStatus = 0x0012ed10)+0xd5d (FPO: [Non-Fpo]) (CONV: thiscall) [r:\mozilla\content\xul\content\src\nsxulelement.cpp @ 1904]
1d gklayout!nsXULElement::HandleDOMEvent(class nsPresContext * aPresContext = 0x02255ae0, class nsEvent * aEvent = 0x0012eee8, class nsIDOMEvent ** aDOMEvent = 0x0012ec00, unsigned int aFlags = 0x202, nsEventStatus * aEventStatus = 0x0012ed10)+0xd5d (FPO: [Non-Fpo]) (CONV: thiscall) [r:\mozilla\content\xul\content\src\nsxulelement.cpp @ 1904]
1e gklayout!nsXULElement::HandleDOMEvent(class nsPresContext * aPresContext = 0x02255ae0, class nsEvent * aEvent = 0x0012eee8, class nsIDOMEvent ** aDOMEvent = 0x0012ec00, unsigned int aFlags = 0x207, nsEventStatus * aEventStatus = 0x0012ed10)+0xd5d (FPO: [Non-Fpo]) (CONV: thiscall) [r:\mozilla\content\xul\content\src\nsxulelement.cpp @ 1904]
1f gklayout!PresShell::HandleEventInternal(class nsEvent * aEvent = 0x0012eee8, class nsIView * aView = 0x02255388, unsigned int aFlags = 1, nsEventStatus * aStatus = 0x0012ed10)+0x321 (FPO: [Non-Fpo]) (CONV: thiscall) [r:\mozilla\layout\base\nspresshell.cpp @ 6090]
20 gklayout!PresShell::HandleEvent(class nsIView * aView = 0x02255388, class nsGUIEvent * aEvent = 0x0012eee8, nsEventStatus * aEventStatus = 0x0012ed10)+0x614 (FPO: [Non-Fpo]) (CONV: stdcall) [r:\mozilla\layout\base\nspresshell.cpp @ 5830]
21 gklayout!nsViewManager::HandleEvent(class nsView * aView = 0x02255388, struct nsPoint aPoint = struct nsPoint, class nsGUIEvent * aEvent = 0x0012eee8, int aCaptured = 0)+0x57 (FPO: [Non-Fpo]) (CONV: thiscall) [r:\mozilla\view\src\nsviewmanager.cpp @ 1675]
22 gklayout!nsViewManager::DispatchEvent(class nsGUIEvent * aEvent = 0x0012eee8, nsEventStatus * aStatus = 0x0012ee30)+0xc2b (FPO: [Non-Fpo]) (CONV: stdcall) [r:\mozilla\view\src\nsviewmanager.cpp @ 1628]
23 gklayout!HandleEvent(class nsGUIEvent * aEvent = 0x0012eee8)+0x44 (FPO: [Non-Fpo]) (CONV: cdecl) [r:\mozilla\view\src\nsview.cpp @ 175]
24 gkwidget!nsWindow::DispatchEvent(class nsGUIEvent * event = 0x0012eee8, nsEventStatus * aStatus = 0x0012eec8)+0xb5 (FPO: [Non-Fpo]) (CONV: stdcall) [r:\mozilla\widget\src\windows\nswindow.cpp @ 1170]
25 gkwidget!nsWindow::DispatchWindowEvent(class nsGUIEvent * event = 0x0012eee8)+0x24 (FPO: [Non-Fpo]) (CONV: thiscall) [r:\mozilla\widget\src\windows\nswindow.cpp @ 1191]
26 gkwidget!nsWindow::DispatchKeyEvent(unsigned int aEventType = 0x83, unsigned short aCharCode = 0, unsigned int aVirtualCharCode = 0xd, long aKeyData = 1835009, unsigned int aFlags = 0)+0xdc (FPO: [Non-Fpo]) (CONV: thiscall) [r:\mozilla\widget\src\windows\nswindow.cpp @ 3387]
27 gkwidget!nsWindow::OnKeyDown(unsigned int aVirtualKeyCode = 0xd, unsigned int aScanCode = 0x1c, long aKeyData = 1835009)+0x3f8 (FPO: [Non-Fpo]) (CONV: thiscall) [r:\mozilla\widget\src\windows\nswindow.cpp @ 3525]
28 gkwidget!nsWindow::ProcessMessage(unsigned int msg = 0x100, unsigned int wParam = 0xd, long lParam = 1835009, long * aRetValue = 0x0012f400)+0x8cb (FPO: [Non-Fpo]) (CONV: thiscall) [r:\mozilla\widget\src\windows\nswindow.cpp @ 4468]
29 gkwidget!nsWindow::WindowProc(struct HWND__ * hWnd = 0x0c0b095e, unsigned int msg = 0x100, unsigned int wParam = 0xd, long lParam = 1835009)+0x131 (FPO: [Non-Fpo]) (CONV: stdcall) [r:\mozilla\widget\src\windows\nswindow.cpp @ 1359]
2a USER32!InternalCallWinProc+0x28
2b USER32!UserCallWinProcCheckWow+0x150 (FPO: [Non-Fpo])
2c USER32!DispatchMessageWorker+0x306 (FPO: [Non-Fpo])
2d USER32!DispatchMessageW+0xf (FPO: [Non-Fpo])
2e gkwidget!nsAppShell::DispatchNativeEvent(int aRealEvent = 1, void * aEvent = 0x01fd5af8)+0xd (FPO: [Non-Fpo]) (CONV: stdcall) [r:\mozilla\widget\src\windows\nsappshell.cpp @ 221]
2f appshell!nsXULWindow::ShowModal(void)+0x241 (FPO: [Non-Fpo]) (CONV: stdcall) [r:\mozilla\xpfe\appshell\src\nsxulwindow.cpp @ 405]
30 appshell!nsContentTreeOwner::ShowAsModal(void)+0x19 (FPO: [Non-Fpo]) (CONV: stdcall) [r:\mozilla\xpfe\appshell\src\nscontenttreeowner.cpp @ 431]
31 embedcomponents!nsWindowWatcher::OpenWindowJS(class nsIDOMWindow * aParent = 0x00000000, char * aUrl = 0x00d47b48 "chrome://communicator/content/profile/profileSelection.xul", char * aName = 0x0200d4c4 "_blank", char * aFeatures = 0x0200d0c8 "centerscreen,chrome,modal,titlebar", int aDialog = 1, unsigned int argc = 1, long * argv = 0x00d42d20, class nsIDOMWindow ** _retval = 0x0012faac)+0x15a7 (FPO: [Non-Fpo]) (CONV: stdcall) [r:\mozilla\embedding\components\windowwatcher\src\nswindowwatcher.cpp @ 823]
32 embedcomponents!nsWindowWatcher::OpenWindow(class nsIDOMWindow * aParent = 0x00000000, char * aUrl = 0x00d47b48 "chrome://communicator/content/profile/profileSelection.xul", char * aName = 0x0200d4c4 "_blank", char * aFeatures = 0x0200d0c8 "centerscreen,chrome,modal,titlebar", class nsISupports * aArguments = 0x00d47bf0, class nsIDOMWindow ** _retval = 0x0012faac)+0x76 (FPO: [Non-Fpo]) (CONV: stdcall) [r:\mozilla\embedding\components\windowwatcher\src\nswindowwatcher.cpp @ 474]
33 profile!nsProfile::LoadDefaultProfileDir(class nsCString * profileURLStr = 0x0012fd74, int canInteract = 1)+0x51a (FPO: [Non-Fpo]) (CONV: thiscall) [r:\mozilla\profile\src\nsprofile.cpp @ 538]
34 profile!nsProfile::StartupWithArgs(class nsICmdLineService * cmdLineArgs = 0x00d05dc0, int canInteract = 1)+0xa5 (FPO: [Non-Fpo]) (CONV: stdcall) [r:\mozilla\profile\src\nsprofile.cpp @ 352]
35 appcomps!nsAppStartup::DoProfileStartup(class nsICmdLineService * aCmdLineService = 0x00d05dc0, int canInteract = 1)+0x89 (FPO: [Non-Fpo]) (CONV: stdcall) [r:\mozilla\xpfe\components\startup\src\nsappstartup.cpp @ 169]
36 seamonkey!InitializeProfileService(class nsICmdLineService * cmdLineArgs = 0x00d05dc0)+0x13e (FPO: [Non-Fpo]) (CONV: cdecl) [r:\mozilla\xpfe\bootstrap\nsapprunner.cpp @ 900]
37 seamonkey!main1(int argc = 1, char ** argv = 0x003484f8, class nsISupports * nativeApp = 0x00c85fe0)+0x879 (FPO: [Non-Fpo]) (CONV: cdecl) [r:\mozilla\xpfe\bootstrap\nsapprunner.cpp @ 1165]
38 seamonkey!main(int argc = 1, char ** argv = 0x003484f8)+0x1bb (FPO: [Non-Fpo]) (CONV: cdecl) [r:\mozilla\xpfe\bootstrap\nsapprunner.cpp @ 1750]
39 seamonkey!mainCRTStartup(void)+0x12c (FPO: [Non-Fpo]) (CONV: cdecl) [f:\vs70builds\3077\vc\crtbld\crt\src\crtexe.c @ 398]
3a kernel32!BaseProcessStart+0x23 (FPO: [Non-Fpo])

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

*** This bug has been marked as a duplicate of 285465 ***