326849 - VC8 enables RTTI by default

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

VC8 enables RTTI (/GR) by default; we should /GR- the build unless the configure flag is set.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: vc8-exc-rtti-flags.patch

Patch; defines _MOZ_RTTI_FLAGS_{ON,OFF} and _MOZ_EXCEPTIONS_FLAGS_{ON,OFF} for VC8; this makes the --enable-cpp-* configure flags work for both things and defaults to the right thing (no rtti, no exceptions).

Comment 2

[Benjamin Smedberg]

Comment on attachment 211538 [details] [diff] [review]
vc8-exc-rtti-flags.patch

Is there any reason we can't move this hunk out of the version-specific ifs? AFAIK the same flags are valid on all the MSVC versions.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Nope, I just didn't want to accidentally change any of the old build configs suddenly.. though they shuold be safe.  Do you know whether VC6 understands GR and GR-?  (I know VC7 does)

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

checked in, outside of the VC8 conditional (all VC versions)